How to reproduce:
1) Get a custom potion based on water
/give @p minecraft:potion{Potion:"minecraft:water",CustomPotionEffects:[{Id:17,Duration:1200}],display:{Name:"\"Custom Potion\""}}2) Use it on dirt
Expected behavior:
you will attempt to drink the potion, no interaction with the dirt whatsoever (this should affect only plain water bottles without custom effects/colors)
Actual behavior:
potion is used on the dirt consuming the potion and changing dirt into mud.
Linked issues
Comments 5
I don't think so, well those might be fixed probably together, but I am talking strictly about potions not throwable/lingering potions... And they don't mention custom potions either... There needs to be a check whether there are any custom effects to the water on top of check mentioned in that jira...
The thing is, you're using both Potion and CustomPotionEffects, stacking the effects. For exanple, if you set potion to slow_falling, you get slow falling alongside the effect you provide in the CustomPotionEffects. Why should water be any different?
CustomPotionColor and the empty(Uncraftable) potions serve the purpose you're looking for.
Changing the behavior is only going to limit map makers from creating potions which can be used to convert mud, but also be drank for effects.
I mean yes, but it does not make much sense for such a potion to exist - if you want it to be drinkable. It will be a hassle when in a fight you will be facing dirt and instead of drinking you will convert the dirt...
I guess it is up to Mojang to decide whether this is intended or not...
I believe that this is a duplicate of MC-249250, although I'm not too sure.