[MC-256688] Birch wall hanging sign uses "snare" instrument when placed under note block, instead of "bass" as other hanging signs

Steps to Reproduce:
Step 1: Place a random block, then place the birch hanging sign to the side of that block.
Step 2: Place a noteblock on top of the birch wall hanging sign.
Step 3: Press F3, then point to the noteblock, next check the instrument block state of that noteblock.

Observed Results:
Birch wall hanging sign use "snare" instrument when place under noteblock.

Expected Results:
Birch wall hanging sign use "bass" instrument when place under noteblock.

Notes:
This only works for birch wall hanging sign, as the other wall hanging sign, non-wall hanging sign (including birch) will use "bass" instrument.

Attachments

Comments 3

ampolive 2023-03-11T17:37:49Z

Code analysis (Mojang mappings, 1.19.4-rc2): For whatever reason, in the Blocks file, BIRCH_WALL_HANGING_SIGN is registered with the properties of the SAND material instead of the WOOD material like other wall hanging signs:

...
public static final Block OAK_WALL_HANGING_SIGN = Blocks.register("oak_wall_hanging_sign", new WallHangingSignBlock(BlockBehaviour.Properties.of(Material.WOOD, OAK_LOG.defaultMaterialColor()).noCollission().strength(1.0f).requiredFeatures(FeatureFlags.UPDATE_1_20).dropsLike(OAK_HANGING_SIGN), WoodType.OAK));
    public static final Block SPRUCE_WALL_HANGING_SIGN = Blocks.register("spruce_wall_hanging_sign", new WallHangingSignBlock(BlockBehaviour.Properties.of(Material.WOOD).noCollission().strength(1.0f).dropsLike(SPRUCE_HANGING_SIGN).requiredFeatures(FeatureFlags.UPDATE_1_20), WoodType.SPRUCE));
    public static final Block BIRCH_WALL_HANGING_SIGN = Blocks.register("birch_wall_hanging_sign", new WallHangingSignBlock(BlockBehaviour.Properties.of(Material.SAND).noCollission().strength(1.0f).dropsLike(BIRCH_HANGING_SIGN).requiredFeatures(FeatureFlags.UPDATE_1_20), WoodType.BIRCH));
...

The SAND material causes the SNARE sound to play, while the WOOD material causes the BASS sound to play (see NoteBlockInstrument enum).

Brain81505 2023-04-05T15:52:21Z

No longer confirm in 23w14a

ampolive 2023-04-05T18:00:40Z

Can confirm fixed in 23w14a.