mojira.dev
MC-258279

Particle groups aren't cleared on resource reload

 

When resource packs are reloaded, particles are also cleared in ParticleEngine as shown below in reload.

 

this.particles.clear();
profilerFiller2.startTick();
profilerFiller2.push("upload");
this.textureAtlas.reload(preparations);
profilerFiller2.popPush("bindSpriteSets");

 

However, this doesn't clear tracked particles, such as for the spore blossom, so no more particles in that specific group are able to be spawned until the world is reloaded.

[media]

Clearing trackedParticleCounts when the particles are cleared solves the problem.

this.particles.clear();
+ this.trackedParticleCounts.clear();
profilerFiller2.startTick();
profilerFiller2.push("upload");
this.textureAtlas.reload(preparations);
profilerFiller2.popPush("bindSpriteSets");

The result of this fix is spore blossoms as well as any other particles (future, modded, etc.) still being able to emit particles after a resource reload.

 

Linked issues

Attachments

Comments 0

No comments.

Brandon Silva

mattiasselin

Plausible

Platform

Important

Particles

1.19.2, 1.19.3 Release Candidate 1

1.19.3 Release Candidate 3

Retrieved