[MC-259710] Flaming arrows shot by players do not break powder snow when mob griefing is disabled

How to reproduce:

Run command "/gamerule mobGriefing false"
Place Powder Snow
Obtain a Bow enchanted with Flame
Shoot the Powder Snow with the Bow

Expected result: the snow is broken.

Observed behavior: the snow is not broken, and the arrow passes right through.

I feel that this is unintentional because Player-shot arrows aren't created by mobs, and thus should not be affected by the game rule.

Linked issues

is duplicated by 1

MC-298493 Flame-enchanted bow doesn't break Powder Snow in some worlds Resolved

relates to 1

MC-221842 Burning mobs can still destroy powder snow when gamerule mobgriefing is disabled Resolved

Comments 1

ampolive 2023-02-05T17:54:29Z

Code analysis (Mojang mappings, 23w05a): PowderSnowBlock#entityInside(...) checks if the intersecting entity is on fire and if mob griefing is enabled or the entity is a player. As arrows are not players, they cannot destroy the block:

...
      if ($$3.isOnFire() && ($$1.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING) || $$3 instanceof Player) && $$3.mayInteract($$1, $$2)) {
          $$1.destroyBlock($$2, false);
      }
...

I imagine something like this could be used instead:

...
        boolean isPlayerOrPlayerFiredArrow = false;
        if ($$3 instanceof Player) {
            isPlayerOrPlayerFiredArrow = true;
        }
        if (!isPlayerOrPlayerFiredArrow && $$3 instanceof Arrow) {
            Arrow arrow = (Arrow)$$3;
            Entity arrowOwner = arrow.getOwner();
            if (arrowOwner != null) {
                if (arrowOwner instanceof Player) {
                    isPlayerOrPlayerFiredArrow = true;
                }
            }
        }
        if ($$3.isOnFire() && ($$1.getGameRules().getBoolean(GameRules.RULE_MOBGRIEFING) || isPlayerOrPlayerFiredArrow) && $$3.mayInteract($$1, $$2)) {
            $$1.destroyBlock($$2, false);
        }
...