[MC-265238] trade_rebalance loot tables have a wrong type

Expected

Loot tables for the bundled trade_rebalance packs have the minecraft:chest type.

Actual

Loot tables for the packs have the minecraft:entity type.

Steps to reproduce

Open the JAR file
Check any file under /data/minecraft/datapacks/trade_rebalance/data/minecraft/loot_tables/chests/
The type will be minecraft:entity instead of minecraft:chest

Attachments

Comments 3

gnembon 2023-09-06T13:06:05Z

Is correct. Affects chest loot in various structures

user-f2760 2023-09-06T13:13:09Z

How isit correct? it's container loot, not an entity death loot table, it receives different context from triggering. If it affects more, shouldn't they all be fixed, rather than just leaving them to use the improper type?

Patbox 2023-09-07T10:46:08Z

After checking for myself, can confirm it's the case for datapack ones

[media]

Compared to original loottable

[media]