mojira.dev
MC-311741

Bundle tutorial toast has a hardcoded keybind and inconsistent ID

Text and ID for tutorial.bundleInsert.description are wrong.

Observed Behaviour

The string is: Right Click to add items

Its ID is: tutorial.bundleInsert.description

Title’s ID is: tutorial.bundleInsert.title

Expected Behaviour

Right Click is the name of a button. It should refer to the action for Attack/Destroy in keybindings.

The string should have a variable: %s to add items

The IDs should be: tutorial.bundle_insert.description, tutorial.bundle_insert.title

This would be consistent with other tutorial phases. I’m not sure whether these strings are actually used, but if so they should be fixed.

Note

If those are changed together, the old string can still work for older versions while the new one will be used for future versions. Do not just add a variable without changing its ID, otherwise new versions will read Right Button to add items while the older ones will have literally %s to add items with literal %s.

The ID for tutorial.socialInteractions.* should also be tutorial.social_interactions.*, but these don’t need to be changed so it might become a duplicate string rather than a consistency fix and socialInteractions is used in other places too, bundleInsert isn’t.

Comments 1

The button for interacting with bundles cannot be rebound

Lorenzo Federici

(Unassigned)

Unconfirmed

26.3 Pre-Release 2

Retrieved