Whitelist requires lower case names to work

Just came here to report the same bug. Can confirm, /whitelist add YourUsername does not work as expected on 1.4.7.

Can confirm.
The server will lowercase the whitelist.txt when restarted, before that, no login is possible.

Starting server with empty whitelist.txt and issuing whitelist add KuMaSaSa at the server console (CamelCase just for testing purposese, but makes no difference if username is spellt correctly):

2013-02-05 20:19:42 [INFO] Starting minecraft server version 13w05b
2013-02-05 20:19:42 [INFO] Loading properties
2013-02-05 20:19:42 [INFO] Default game type: SURVIVAL
2013-02-05 20:19:42 [INFO] Generating keypair
2013-02-05 20:19:43 [INFO] Starting Minecraft server on *:25565
2013-02-05 20:19:43 [INFO] Preparing level "new-world"
2013-02-05 20:19:43 [INFO] Preparing start region for level 0
2013-02-05 20:19:44 [INFO] Preparing spawn area: 75%
2013-02-05 20:19:44 [INFO] Done (1,325s)! For help, type "help" or "?"
2013-02-05 20:19:48 [INFO] /127.0.0.1:63424 lost connection
2013-02-05 20:19:50 [INFO] Disconnecting Kumasasa [/127.0.0.1:63425]: You are not white-listed on this server!
2013-02-05 20:20:03 [INFO] Added KuMaSaSa to the whitelist
2013-02-05 20:20:12 [INFO] Disconnecting Kumasasa [/127.0.0.1:63433]: You are not white-listed on this server!
2013-02-05 20:20:53 [INFO] Stopping the server

Restarting, login is possible:

2013-02-05 20:20:59 [INFO] Starting minecraft server version 13w05b
2013-02-05 20:20:59 [INFO] Loading properties
2013-02-05 20:20:59 [INFO] Default game type: SURVIVAL
2013-02-05 20:20:59 [INFO] Generating keypair
2013-02-05 20:20:59 [INFO] Starting Minecraft server on *:25565
2013-02-05 20:20:59 [INFO] Preparing level "new-world"
2013-02-05 20:20:59 [INFO] Preparing start region for level 0
2013-02-05 20:21:00 [INFO] Done (1,110s)! For help, type "help" or "?"
2013-02-05 20:21:22 [INFO] Kumasasa[/127.0.0.1:63450] logged in with entity id 70 at (-841.645117534349, 62.0, -1101.0713738942434)

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

I'm getting strange behavior on this. When I take an old test server from 1.4.7, upgrade the jar to 1.5, clear white-list.txt, and start the server, the bug still exists:

2013-03-18 18:29:45 [INFO] Starting minecraft server version 1.5
2013-03-18 18:29:45 [INFO] Loading properties
2013-03-18 18:29:45 [INFO] Default game type: SURVIVAL
2013-03-18 18:29:45 [INFO] Generating keypair
2013-03-18 18:29:45 [INFO] Starting Minecraft server on *:25565
2013-03-18 18:29:45 [INFO] Preparing level "world4"
2013-03-18 18:29:45 [INFO] Preparing start region for level 0
2013-03-18 18:29:46 [INFO] Preparing spawn area: 80%
2013-03-18 18:29:46 [INFO] Done (1.246s)! For help, type "help" or "?"
whitelist list
2013-03-18 18:29:56 [INFO] There are 0 (out of 2 seen) whitelisted players:
2013-03-18 18:29:56 [INFO] 
whitelist add DMBuce
2013-03-18 18:30:01 [INFO] Added DMBuce to the whitelist
2013-03-18 18:30:08 [INFO] Disconnecting DMBuce [/127.0.0.1:32934]: You are not 
white-listed on this server!
whitelist add dmbuce
2013-03-18 18:30:14 [INFO] Added dmbuce to the whitelist
2013-03-18 18:30:17 [INFO] DMBuce[/127.0.0.1:32940] logged in with entity id 331
 at (173.5, 68.0, 68.5)
whitelist list
2013-03-18 18:30:32 [INFO] There are 2 (out of 2 seen) whitelisted players:
2013-03-18 18:30:32 [INFO] DMBuce and dmbuce

If I nuke the server directory completely and start fresh, the bug goes away, so it apparently only affects servers that existed before 1.5 for some reason.

If I nuke the server directory completely and start fresh, the bug goes away, so it apparently only affects servers that existed before 1.5 for some reason.

NVM about this, I had forgotten to re-enable whitelisting after nuking the server dir. The bug exists regardless of whether the server was upgraded from 1.4 or started fresh in 1.5.

2013-03-18 19:09:14 [INFO] Starting minecraft server version 1.5
2013-03-18 19:09:14 [INFO] Loading properties
2013-03-18 19:09:14 [WARNING] server.properties does not exist
2013-03-18 19:09:14 [INFO] Generating new properties file
2013-03-18 19:09:14 [INFO] Default game type: SURVIVAL
2013-03-18 19:09:14 [INFO] Generating keypair
2013-03-18 19:09:14 [INFO] Starting Minecraft server on *:25565
2013-03-18 19:09:14 [WARNING] Failed to load operators list: java.io.FileNotFoundException: ./ops.txt (No such file or directory)
2013-03-18 19:09:14 [WARNING] Failed to load white-list: java.io.FileNotFoundException: ./white-list.txt (No such file or directory)
2013-03-18 19:09:14 [INFO] Preparing level "world"
2013-03-18 19:09:15 [INFO] Preparing start region for level 0
2013-03-18 19:09:16 [INFO] Preparing spawn area: 8%
2013-03-18 19:09:17 [INFO] Preparing spawn area: 23%
2013-03-18 19:09:18 [INFO] Preparing spawn area: 38%
2013-03-18 19:09:19 [INFO] Preparing spawn area: 53%
2013-03-18 19:09:20 [INFO] Preparing spawn area: 69%
2013-03-18 19:09:21 [INFO] Preparing spawn area: 85%
2013-03-18 19:09:22 [INFO] Done (7.234s)! For help, type "help" or "?"
2013-03-18 19:09:23 [INFO] DMBuce[/127.0.0.1:33235] logged in with entity id 232 at (128.5, 68.0, 257.5)
2013-03-18 19:09:26 [INFO] DMBuce lost connection: disconnect.quitting
2013-03-18 19:09:29 [WARNING] Can't keep up! Did the system time change, or is the server overloaded?
whitelist on
2013-03-18 19:09:30 [INFO] Turned on the whitelist
2013-03-18 19:09:38 [INFO] Disconnecting DMBuce [/127.0.0.1:33242]: You are not white-listed on this server!
whitelist add DMBuce
2013-03-18 19:09:43 [INFO] Added DMBuce to the whitelist
2013-03-18 19:09:47 [INFO] Disconnecting DMBuce [/127.0.0.1:33248]: You are not white-listed on this server!
whitelist add dmbuce
2013-03-18 19:09:53 [INFO] Added dmbuce to the whitelist
2013-03-18 19:09:57 [INFO] DMBuce[/127.0.0.1:33254] logged in with entity id 3124 at (128.5, 68.0, 257.5)

I can confirm this bug still exists in 1.5.2. How to reproduce:

(1) Start server
(2) Try to whitelist a player by either
(2a) using the server console (e.g. "whitelist add DMBuce")
(2b) using command in-game (e.g. "/whitelist add DMBuce")
(3) Note the logging message returned by the server: "You are not white-listed on this server!"
(4) Next, whitelist the player but use all lowercase (e.g. "whitelist add dmbuce")
(5) Note the successful logged in message.

I apologize in advance if it is wrong to do this but I looked over the (deobfuscated) source code via Minecraft Coder Pack (MCP). Having done so I can describe why users such as myself and Buce above are seeing this bug.

I'm going to use the MCP package/class names. These names probably don't align with the official Mojang source but hopefully it will be clear which part of the source tree is being referenced. Also, MCP decompiles the source into two directories: src/minecraft and src/minecraft_server. I'll be talking about files in the latter.

How the bug happens:
(1) In net.minecraft.src.ServerConfigurationManager the method addToWhitelist() looks like this:
public void addToWhiteList(String par1Str) {
this.whiteListedPlayers.add(par1Str);
}

(2) In net.minecraft.src.DedicatedPlayerList the method isAllowedToLogin() looks like this:
public boolean isAllowedToLogin(String par1Str) {
par1Str = par1Str.trim().toLowerCase();
return [snip] || [snip] || this.getWhiteListedPlayers().contains(par1Str);
}

So when adding to the whitelist, the username string is added exactly. However, when checking the whitelist, the username string is first modified to its lowercase version. Hence the bug.

Workarounds:
(1) Obviously, just enter the username in all lowercase.
(2) Enter the username in mixed-case and either (a) reload the whitelist using the "reload" command, or (b) re-start the server.

Reloading or re-starting the server fixes the problem because in net.minecraft.src.DedicatedPlayerList the method readWhiteList() modifies the entries in white-list.txt to lowercase when it reads it in:
private void readWhiteList() {
try
{
this.getWhiteListedPlayers().clear();
BufferedReader var1 = new BufferedReader(new FileReader(this.whiteList));
String var2 = "";

while ((var2 = var1.readLine()) != null)
{
this.getWhiteListedPlayers().add(var2.trim().toLowerCase());
}

var1.close();
}
catch (Exception var3)
{
[snip];
}
}

So in summary, isAllowedToLogin() and readWhiteList() both transform usernames to lowercase but addToWhiteList() does not. That's how the bug arises. It looks like the easiest way to fix it is to call toLowerCase() in addToWhiteList(). If that is actually implemented, care should be taken to call toLowerCase() in the method removeFromWhiteList() as well.