[MC-4065] Messages/commands sent while in a bed won't be remembered in sent history

The bug

When in a bed, typing and submitting a message and/or command will be forgotten if you try to access that with the arrow keys while out of bed.

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

is duplicated by 8

MC-18945 If you type something while in bed, then you leave the bed and press on up button while in chat, you won't see that you wrote anything Resolved

MC-27386 Messages sent while in a bed won't be remebered in sent history Resolved

MC-43667 Chat history in beds Resolved

MC-50080 Chatting In Beds Don't Save History Resolved

MC-53031 typing while sleeping wil not remember the word you typed Resolved

3 more links

relates to 3

MC-105303 Bed chat GUI not resetting sent messages history index after sending a message Open

MC-160710 Chat messages written while sleeping are deleted after waking up Resolved

MC-127573 Hover text is displayed for multiplayer chat while in bed even if chat is hidden Resolved

Attachments

Comments 22

CubeTheThird 2012-12-15T20:22:25Z

Can confirm.

Tails 2013-03-16T00:51:51Z

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

Lucas Jed 2013-08-07T02:01:23Z

I'll just say I can also confirm this!

Ezekiel 2014-02-24T14:15:52Z

Is this still a concern in the latest Minecraft version 14w08a? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

marcono1234 2014-06-01T15:35:04Z

Confirmed for 14w21b

12 more comments

Eric 2014-08-24T18:15:31Z

Confirmed for 1.8pre1 and before. This is a little annoying, but not game breaking, but I think the fix shouldn't take much.

C_moneySmith 2014-11-08T02:12:10Z

confirmed for 1.8 official release

ZuzuTyp 2015-08-19T14:29:41Z

confirmed for 15w34a

marcono1234 2015-12-12T18:05:30Z

Confirmed for

15w50a

The reason for that is that currently the method keyTyped(char typedChar, int keyCode) in the class /Client/src/net/minecraft/client/gui/GuiSleepMP.java (MCP 1.8 names) calls this.mc.thePlayer.sendChatMessage(var3); which directly sends the message to the server, however it should call instead the method func_175275_f(String p_175275_1_).

/**
 * Fired when a key is typed (except F11 who toggle full screen). This is the equivalent of
 * KeyListener.keyTyped(KeyEvent e). Args : character (character on the key), keyCode (lwjgl Keyboard key code)
 */
protected void keyTyped(char typedChar, int keyCode) throws IOException
{
	if (keyCode == 1)
	{
		this.wakeFromSleep();
	}
	else if (keyCode != 28 && keyCode != 156)
	{
		super.keyTyped(typedChar, keyCode);
	}
	else
	{
		String var3 = this.inputField.getText().trim();

		if (!var3.isEmpty())
		{
			// Changed this
			this.func_175275_f(var3);
			//this.mc.thePlayer.sendChatMessage(var3);
		}

		this.inputField.setText("");
		this.mc.ingameGUI.getChatGUI().resetScroll();
	}
}

Note: For Minecraft 1.10 decompiled using MCP 9.30 the method that should be called is net.minecraft.client.gui.GuiScreen.sendChatMessage(String).

Immaterialise 2016-02-17T19:38:28Z

Confirmed for 1.9-pre1

null 2016-07-13T01:19:28Z

I can definitely confirm for 1.10.2. I've also noticed a second (related) bug:

Send the messages "#1", "#2", and "#3" in that order. Hop onto a bed and press the up arrow key twice, then Enter, to resend the "#2" message. Now, when you press the up arrow key again, "#1" will be displayed instead of "#3".

Can anyone summarize the above in one sentence? 😛

marcono1234 2016-07-13T12:37:20Z

Good catch!

It is now MC-105303. I hope the title fits well 🙂

And sorry for stealing you the chance for a code analysis 😃
But we should not fight about that. I hope the one provided is correct