[MC-45749] Potion particles spread always from the north-west corner of a block, regardless of impact

The bug

The potion particles are not spawning in the middle of the block. They're spawning on the edge of the block. Does not happen when you use the following command with a command block:

/particle <particle> ~0 ~1 ~0 0 0 0 1 1

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

is duplicated by 29

MC-60528 When throwing potions, particles display elsewhere than where the entity hits the ground Resolved

MC-68044 Splash potion particles are always at X: -.0 Z: -.0 Resolved

MC-68785 Potion particles spawn wrong position when hit on the ground Resolved

MC-69534 Splash potion particles on wrong location Resolved

MC-76768 Thrown Enchanted bottle is displayed in the wrong place Resolved

24 more links

relates to 11

MC-146740 Magma bubble column particles are misaligned Open

MC-196142 Basalt delta particles move in random directions in Bedrock, but northwest on Java Open

MC-161888 Enchantment tables do not track the player correctly at high distances from the world origin Resolved

MC-163027 Mob and player particles are offset Resolved

MC-189857 Potion particles spread always from the center of a block, regardless of impact Open

6 more links

Attachments

Comments 37

Squid Eevee 2014-01-24T17:47:36Z

Use absolute coordinates and add .5 to the end of the x and z coordinates. It's the only advice I can offer.

kumasasa 2014-02-04T21:48:00Z

Fixed in 14w05b.

Tested with

/particle mobSpell ~0 ~1 ~0 0 0 0 1 5

migrated 2014-07-04T19:44:00Z

Please re-open this issue. The bug is still prevalent in 14w27b. No matter where you throw a splash potion, the particles only appear on the North-West corner of the block they landed on.

kumasasa 2014-07-04T20:12:53Z

Reopened and confirmed.

migrated 2014-08-22T10:01:04Z

Confirmed 1.8-pre1

27 more comments

migrated 2014-08-25T15:39:46Z

Confirmed 1.8-pre2

migrated 2014-10-07T19:35:48Z

Affects 1.8.

Marcono1234 2015-01-09T14:51:24Z

Confirmed for

1.8.2-pre1

migrated 2015-03-12T06:42:45Z

Still affects 1.8.3.

migrated 2015-05-16T02:03:17Z

Affects 1.8.4

migrated 2015-05-23T16:39:43Z

Still affecting 1.8.5 : http://prntscr.com/78hpcl

migrated 2015-07-29T19:39:12Z

Affects 15w31a!

Sonicwave 2015-08-06T18:37:43Z

Confirmed for 15w32b.

migrated 2015-08-12T15:18:30Z

Still confirmed for 15w33a. I hope this gets fixed now there are new Lingering potions

migrated 2015-08-13T13:20:19Z

Affects 15w33b.

migrated 2015-08-20T09:04:57Z

Affects 15w34a.

migrated 2015-08-24T08:54:44Z

Affects 15w34d.

migrated 2015-08-24T14:47:04Z

Mathias K.: Since the original reporter seems inactive I've given you the ticket. Take good care of it 🙂

Michael Wobst 2015-11-18T17:05:22Z

Bug confirmed for 15w47a.

migrated 2015-11-20T01:29:08Z

Bug is still existent in 15w47b.

migrated 2015-11-22T02:40:21Z

This bug affects 15w47c.

Marcono1234 2015-12-12T13:13:22Z

Confirmed for

15w50a

The reason for that is that the method playAuxSFX(int p_175718_1_, BlockPos p_175718_2_, int p_175718_3_) in the /Client/src/net/minecraft/world/World.java class takes a BlockPos as argument (MCP 1.8 names). However BlockPos can only store three integers. This is also the reason why for example doors being broken display their particles in the center of the block (very likely). This method is not only used for rendering but also for the sound, which is the reason why the method used by the /particle command cannot be used for potions (as well as the fact that that method ignores the particle settings).

Edit: There are actually two methods of the net.minecraft.world.World class that could be used instead (together):

playSoundEffect(double x, double y, double z, String soundName, float volume, float pitch)
spawnParticle(EnumParticleTypes p_175688_1_, double p_175688_2_, double p_175688_4_, double p_175688_6_, double p_175688_8_, double p_175688_10_, double p_175688_12_, int ... p_175688_14_)

migrated 2016-05-12T16:13:33Z

still in 1.9.4

CreeperMagnet_ 2017-12-30T21:01:02Z

Can confirm for 17w50a. Please update the affected versions for said version.

CreeperMagnet_ 2018-02-06T02:24:58Z

Still affects 18w05a, please update!

CreeperMagnet_ 2018-03-02T00:10:37Z

Affects 18w09a.

migrated 2018-03-03T09:39:02Z

Yet confirmed in latest -release and -snapshot versions. Seems to be a simple bug with unnecessary float -> integer conversions of x/y/z coordinates.

CreeperMagnet_ 2018-07-05T17:25:37Z

Affects 1.13-pre6. Please keep the issue updated accordingly.

muzikbike 2018-07-10T16:45:47Z

Affects 1.13-pre7

gaspoweredpick 2019-03-29T02:46:26Z

It also seems like the spread not only offsets to negative X and Z coordinates, but also to a negative Y coordinate. You could make splash potions sink into the ground by throwing them on end portal frames at a certain angle. The same applies to slabs and most slab-like blocks.

migrated 2019-09-01T17:51:32Z

Present in 1.14.4 and all prior versions...

The packet for splash potions takes integers for the location, instead of floats or doubles.

Issue should probably be updated to include a feature request to change location parameters of (World) Effect packet ID 0x22 (34) to some floating point types.

Unfortunately, almost all of the effects that can be sent from this packet, make sense to only use block location, so this is probably not a big concern for the developers.

muzikbike 2019-10-02T14:50:09Z

Relates closely to MC-76810

migrated 2019-12-13T14:48:08Z

Affects 1.15 and 1.15.1 pre-release 1.

pneuma 2020-01-21T23:44:52Z

Also Eye of Ender broken particles are offset.

[media]

Marcono1234 2020-02-19T22:44:12Z

@@unknown, that is a separate issue and I created MC-172739 for it and attached your video there.
Please comment on it if you want to become the reporter.

numeritos 2020-06-12T14:57:47Z

Affects 1.16 pre5

migrated 2020-06-15T17:41:32Z

Resolved? in 1.16 Pre-release 6.
Splash potion particles now always spread from the center of the block, regardless of impact