[MC-46766] Breaking particles, sounds, and block cracks can be created in spectator mode

The bug

If you start breaking a block in survival mode and switch to spectator mode, that block gains the ability to show the breaking animation.

How to reproduce

Go into survival mode
Start breaking a block, but do not finish
Let go of left click and switch to spectator mode
Attempt to break the same block
→ Notice the breaking animation and particles

Note: Blocks cannot be broken in this way, but in singleplayer you can see the animation. Not sure if others in SMP can see these particles.

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

is duplicated by 9

MC-55233 Mining a block in Creative, then changing to Spectator creates breaking particles Resolved

MC-70230 players in gamemode 2 can still have block-breaking animation Resolved

MC-206275 Spectator can produce mine particles Resolved

MC-215163 Spectators can produce client-side breaking particles without the animation Resolved

MC-215839 Spectators can create break particles Resolved

4 more links

relates to 2

MC-19676 Breaking particles, sounds, and block cracks can be created in adventure mode Reopened

MC-9998 Breaking blocks in Creative can produce particles from blocks behind the broken block Reopened

Attachments

MC-46766.mp4

Comments 57

Deleted account 2014-04-02T05:12:34Z

Is this still a concern in the current Minecraft version 14w11b or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. - bot

Itouch2 2014-05-05T17:48:53Z

Confirmed for 14w18b.

Itouch2 2014-05-11T10:24:54Z

Confirmed for 14w19a.

Itouch2 2014-05-15T18:58:21Z

Confirmed for 14w20a and b.

marcono1234 2014-05-24T13:38:35Z

Confirmed for 14w21b

47 more comments

shufboyardee 2014-06-19T17:26:30Z

Confirmed for 14w25b

shufboyardee 2014-06-25T17:12:52Z

and for 26b.

shufboyardee 2014-07-10T15:30:54Z

and 28b.. and 29b.. and 30c.. and 32a

Eric 2014-08-06T23:59:23Z

By the way, thank you for keeping up on this so well, I haven't been able to keep on top of it lately. As far as I know, still a problem, client-side, although not an urgent one. It just may have other implications that i am unaware of, such as the client being unaware of restrictions accidentally.

shufboyardee 2014-08-13T16:23:21Z

No problem! It sort of goes hand-in-hand with my bug MC-55233, so i always check both.
Confirmed for 14w33a.

Sonicwave 2014-10-17T03:23:01Z

Confirmed for 1.8 and 1.8.1-pre2.

shufboyardee 2014-11-10T16:16:55Z

and 1.8.1-pre4, and 1.8.2-pre4.

KingSupernova 2015-01-19T23:44:19Z

Also occurs in multiplayer, but other player can't see the animation.

shufboyardee 2015-02-26T14:20:42Z

And 1.8.3, and 1.8.6 ... and 15w31b

Eric 2015-07-30T23:04:44Z

Thanks for keeping tabs on this issue, as I've not been able to check on it for a while. An interesting little bug, hope it gets noticed.

shufboyardee 2015-08-12T15:48:56Z

No problem at all.
Still in 15w33b.

Eric 2015-08-22T20:04:08Z

When I found the bug, I did not require holding left click between gamemodes, simply having partially broken the block before the gamemode switch was enough. Is this no longer the case?

shufboyardee 2015-08-24T16:48:46Z

Eric: It's still the case – if I understand you correctly: I always test for this bug by partially breaking a block, releasing, then switching gamemodes.
Still affects 15w35b.

Eric 2015-08-24T18:32:44Z

Alright, then the edit was incorrect? I'll switch it back until notified otherwise.

shufboyardee 2015-09-02T20:57:57Z

Still in 36c – Oh I didn't notice the edit! It looks good now anyway.
And still in 47a.

kumasasa 2015-11-18T19:01:55Z

@@unknown: Please write "15w47a" instead of "47a" when mentioning affected versions, otherwise that may slip through some filters.

shufboyardee 2015-11-19T17:12:55Z

Sure, thanks, I didn't know about such things. Confirmed in 15w50a.

Eric 2015-12-09T21:48:29Z

Is it also confirmed for 1.8.9? I'm forgetting. Thank you once again for keeping me updated!

shufboyardee 2015-12-17T16:39:55Z

You're welcome! Confirmed for 1.8.9, and snapshots through 16w04a.

Eric 2016-01-28T17:09:37Z

If you want the bot to do it automatically, I think it requires a new comment. But I'm getting your edits just fine, and I like updating it, so either way works. Just FYI 🙂

user-f2760 2016-01-28T17:10:59Z

@unknown no bots update the affected versions, mod do, and indeed a new comment would be much more noticable then a edited comment

Eric 2016-01-28T17:30:30Z

Alright, thank you for the clarification. I just assumed "Filter" meant to catch update notifications, possibly for a bot. For some reason, I seem to remember a mod bot updating it for me, but the logs appear to show that I remember incorrectly there as well.

[Mod] redstonehelper 2016-01-28T21:50:05Z

We have a bot to remove future versions from affected versions. The reason we want the whole snapshot version spelled out is so it's easier to parse quickly. The reason we want a new comment is so it shows up in the activity feed and not just in email inboxes.

Eric 2016-01-29T02:03:08Z

Alright, thank you for clearing that up.

shufboyardee 2016-02-03T17:50:30Z

Oh, I can do new comments if that's better. Confirmed in 16w05a.

shufboyardee 2016-02-04T17:05:29Z

Affects 16w05b.

shufboyardee 2016-02-15T18:25:27Z

Affects 16w06a and 16w07a.

shufboyardee 2016-02-16T16:49:13Z

Affects 16w07b.

shufboyardee 2016-02-17T17:06:44Z

Affects 1.9 Pre-release 1.