mojira.dev
MC-61765

tellraw/books (json-stuff) doesn't work with @e[...] and displaying its score

When displaying an entity's score in chat, it will not display.
However, when using a player or a fake player, it works just fine.
What I expected to happen:
The chat would display "1" for the player and the entity

What actually happened:
The chat displays a "1" for the player and any fake player, but doesn't with selectors

Steps to reproduce:
Create a new flat world type "redstoneready", to make sure no mobs spawn
Spawn a Pig

/scoreboard objectives add test dummy
/scoreboard objectives setdisplay sidebar test
/scoreboard players set @e test 1

Now you should have two players in the sidebar that have a score of 1 for objective test

After this, do the following tellraws:

/tellraw @a {"score":{"name":"@p","objective":"test"}}
/tellraw @a {"score":{"name":"@e[type=Pig]","objective":"test"}}

This displays "1" for the first tellraw, but displays a blank line for the second tellraw

You can do another tellraw to test if the @e selector specifically is broken:

/tellraw @a {"score":{"name":"@e[type=Player]","objective":"test"}}

Displays "1" aswell, showing that this is actually a problem with entity's specifically.

From @unknown's comment:

I used MCP to decompile Minecraft and had a look in the corresponding class and I think I found the problem.

For some reason the game creates two net.minecraft.util.ChatComponentScore, one that contains the raw input and then one that contains the parsed name and then uses the second one to display the score.However for the parsed one it uses the getName() method. This means for an ArmorStand for example it will return "Armor Stand" which is of course neither a valid player name nor a valid UUID.

To fix this some code would be needed to make the game use the UUID instead of the name when an entity is selected.

Possible fix (1.8)

List var6 = PlayerSelector.func_179656_b(p_179985_0_, var5, Entity.class);

if (var6.size() != 1)
{
    throw new EntityNotFoundException();
}

Entity selectorEntity = ((Entity)var6.get(0));
if (selectorEntity instanceof EntityPlayerMP) {
	var5 = selectorEntity.getName();
}
else {
	var5 = selectorEntity.getUniqueID().toString();
}

This is the only code change needed. The wildcard parsing will work the way it currently is (if I understand it correctly), as the recipient can currenlty only be a player (for entities it fails as it would then use the name again). However for the future it might be a good idea to change this as well.

Linked issues

Comments 21

Still doesnt work in 14w29b.
But now it returns that the entity cant be found. What i did to test it:

/scoreboard players set @e[name=-9-] wood 1

Note: 9 is a WitherSkull with a Custom Name.

/tellraw @a {"text":"","extra":[{"score":{"name":"@e[score_wood_min=1]","objective":"wood"}}]}

Result: Chat says "That entity cannot be found"

yo yo yo, doesn't work in 1.8 confirmedamundo. Tried to use it on a sign and no dice.

cannot confirm.
That

/scoreboard objective add test dummy
/scoreboard players set @p test 1
/tellraw @a {"text":"","extra":[{"score":{"name":"@e[score_test_min=1]","objective":"test"}}]}

displays "1"

The How to reproduce is incorrect, it should be:

Create a flat world, preferably redstoneready so that no animals can spawn
Spawn a Pig

/scoreboard objectives add temp dummy
/scoreboard players set @e[type=Pig] temp 5
/scoreboard players set @p temp 5
/tellraw @a {score:{name:'@p',objective:'temp'}}
/tellraw @a {score:{name:'@e[type=Pig,c=1]',objective:'temp'}}

The first tellraw outputs the number 5

The second tellraw outputs an empty line

As you can see it works with selectors, but it just works for players and not for other entity's
Also, this is still an issue in the latest version of minecraft: (Minecraft-1.8.1)

Please reopen as this is still an issue in the current version of minecraft: 1.8.1

11 more comments

Confirmed in 15w44b. The workaround for now is to use /scoreboard players operation to copy the value over to a #fake player and then use that, but it's a bit cumbersome; this bug is worth fixing.

Updated for 15w47c & updated tellraws to strict JSON

Confirmed for 16w04a.

Confirmed fixed for 16w07a

Sebastian K

lennart van hirtum

michael

Community Consensus

Minecraft 14w28b, Minecraft 1.8, Minecraft 1.8.1, Minecraft 1.8.2-pre1, Minecraft 1.8.2-pre3, ..., Minecraft 15w50a, Minecraft 15w51b, Minecraft 16w02a, Minecraft 16w04a, Minecraft 16w06a

Minecraft 16w07a

Retrieved