[MC-65198] "minecraft.crafted:minecraft.<ITEM>" doesn't increase correctly when crafting items with shift-click or drop actions

The Bug:

"minecraft.crafted:minecraft.<ITEM>" doesn't increase correctly when crafting items with shift-click or drop actions.

Steps to Reproduce:

Drop action:

Create a scoreboard objective for tracking when you craft some stone bricks and set it to display on the sidebar by using the commands provided below.
```
/scoreboard objectives add CraftStoneBricks minecraft.crafted:minecraft.stone_bricks
```
```
/scoreboard objectives setdisplay sidebar CraftStoneBricks
```
Obtain a stack of stone and place down a crafting table.
Open the crafting table and craft four stone bricks by left-clicking the output slot in the crafting table.
Take note of how the scoreboard correctly increases by a value of "4" as you have crafted four stone bricks.
Craft four stone bricks once again, but this time use the drop action function to craft the items by pressing your drop key whilst holding your mouse cursor over the output slot in the crafting table.
Take note of how the scoreboard only increases by a value of "1" despite crafting four stone bricks.

Shift-click:

Create a scoreboard objective for tracking when you craft some stone bricks and set it to display on the sidebar by using the commands provided below.
```
/scoreboard objectives add CraftStoneBricks minecraft.crafted:minecraft.stone_bricks
```
```
/scoreboard objectives setdisplay sidebar CraftStoneBricks
```
Obtain a stack of stone and place down a stonecutter.
Open the stonecutter and craft a singular stone brick block by left-clicking the output slot in the stonecutter.
Take note of how the scoreboard correctly increases by a value of "1" as you have crafted one stone brick block.
Craft a stone brick block once again, but this time hold your mouse cursor over the output slot in the stonecutter and shift-click.
Take note of how the scoreboard doesn't increase despite crafting a stone brick block.

Observed Behavior:

"minecraft.crafted:minecraft.<ITEM>" doesn't increase accordingly.

Expected Behavior:

"minecraft.crafted:minecraft.<ITEM>" would increase accordingly.

Related issues

is duplicated by

MC-68773 Take craft items with right click (only without Shift+click) or with Drop Item button don't affect scoreboard normaly.

MC-161869 Crafted item statistics do not account for non-one stacksizes when crafted by pressing DROP

MC-183371 Item statistics incorrectly add the halved stack amount on right click of a crafted item

MC-263783 Items crafted in the Stonecutter don't count towards "Times Crafted" in the statistics menu

MC-267583 Scoreboard ItemCrafted Bug (when right clicking in crafting table)

MC-269174 Wrong "Times Crafted" statistics increment when pressing Q (drop) on crafting table result

relates to

MC-64119 stat.drop wont increase when Player throws Items out of his Inventory screen

MC-202164 "Times Crafted" statistics & corresponding objectives increase incorrectly when using the stonecutter

MC-202166 "Times Crafted" statistics column doesn't always display data correctly

Attachments

MC-65198 - Drop Action.mp4

MC-65198 - Shift-click.mp4

Comments

migrated 2014-08-03T11:47:48Z

[media][media][media][media][media]

marcono1234 2015-03-28T12:45:10Z

Relates to:

MC-64119

migrated 2017-05-22T16:32:24Z

I can't confirm it for example in 1.12 pre-release 5 because objective's criteria stat.craftItem.minecraft.planks has been remove of game 😞

But confirm for 1.12 pre-5 with an other example: craftItem.minecraft.redstone

violine1101 2017-05-22T16:59:54Z

You can still check the statistics page, can't you? Also, it's stat.craftIetm.minecraft.planks, not stat.craftIetm.minecraft:planks

migrated 2017-05-22T17:09:03Z

It's edit thx 🙂
Always this problem so.

migrated 2018-09-03T19:27:49Z

Confirmed for 1.13.1.

bluecrab2 2020-04-15T03:48:59Z

Confirmed in 20w15a

bluecrab2 2020-07-13T16:31:06Z

Confirmed in 20w28a

pulpetti 2020-07-13T17:46:27Z

Confirmed in 1.16.1

migrated 2020-10-23T18:08:51Z

Same problem with smithing tables

marcono1234 2020-11-08T22:58:20Z

@@unknown, could you please clarify what you mean by that? All vanilla smithing table recipes only yield 1 result item and for me it correctly updates the statistics when left clicking, right clicking and using the drop item key.
Please also make sure that you are not experiencing MC-202166.

bluecrab2 2020-11-26T06:04:13Z

Confirmed in 20w48a

Johnibur 2020-12-01T15:05:45Z

I have updated the ticket including reproduction steps with the scoreboard system and one UI where this issue happens: the stonecutter.

CreeperMagnet_ 2021-05-10T17:06:54Z

Affects 21w18a.

Avoma 2021-07-26T08:25:26Z

Can confirm in 1.17.1.

Avoma 2021-08-12T12:40:09Z

I'd like to request ownership of this ticket since the current reporter has been inactive for over a year. I'm willing to keep this ticket updated and will continue to provide all of the necessary details.

migrated 2021-08-12T13:07:44Z

I agree. Thanks.

migrated 2022-06-13T17:58:52Z

Affects 1.19

migrated 2023-03-08T17:44:51Z

Affects 1.19.4 pre-release 4.

migrated 2023-12-25T13:41:31Z

This can be traced back in ResultSlot class, as under the "remove" method, the parameter p_40173_ is taking both primary and secondary (splitting) values. As seen in line 414 & 415 in AbstractContainerMenu class.

[media]

This is important because the remove method sets the removeCount as the j3 value (and since right click splits the amount, it's halved). The removeCount is later used to trigger the scoreboard achievement , so the scoreboard achievement is not accurate to what's crafted.

(removeCount being set as the min value - which is the split value)

[media]

(line 43 triggers the scoreboard increment)

[media]

I'm pretty sure this is what is happening to the drop action as well because it thinks you're only removing out 1 item count from the slot.