Fishing line ignores FOV modifiers

Confirmed for 1.7.5 and 14w11b

Confirmed for 14w17a

Confirmed for 14w25b.

Confirmed for 14w29a and b.

Is this fixed in 33b, with the other fishing rod fixes?

Not fixed in 14w33c

Not fixed in 16w43a.

Confirmed for 17w17a

Confirmed for 17w43b

Confirmed for 18w48a

Confirmed for 18w48b

Confirmed for 18w49a

Confirmed for 18w50a

Confirmed for 19w02a

Confirmed for 19w03a

Confirmed for 19w03b

Confirmed for 19w03c

Comfirmed for 19w04a

Confirmed for 19w04b and 19w05a

Confirmed for 19w06a

Confirmed for 19w07a

Confirmed for 19w09a

Confirmed for 19w11a

Confirmed for 19w11b

Confirmed for 19w12a

Confirmed for 19w12b

Confirmed for 19w13a

Confirmed for 19w13b

Confirmed for 19w14a

Confirmed for 19w14b

Confirmed for 1.14 pre-1

As of 1.14-pre2, the fishing rod seems to only connect properly with FOV set to 30.

Confirmed for 1.14 pre-3

Confirmed for 1.14 pre-4

Confirmed for 1.14 pre-5

Confirmed for 1.14

Confirmed for 1.14.1 pre-1

Confirmed for 1.14.1 pre-2

Confirmed for 1.14.1

Confirmed for 1.14.2 pre-3. In first person, the fishing rod's line doesn't fully connect with the rod itself. This is not just an issue with my client, other colleagues have reported the same bug. This happens regardless of resource packs being installed or not. The rod's line does fully connect in third person. See the attached screenshots. 

Confirmed for 1.14.3 pre-1

Fix this already, it bugs my OCD xD

1.14.4

Fishing line doesn't connect to the fishing rod. The gap is kinda smaller right now, but still not correctly connected.

Confirmed in 19w45b.

I would love it this were to be assigned and looked at. It's such an immersion breaking bug for something that pretty much everyone on the Java edition does - changes FOV. 

Attached some screenshots. Line becomes detached at any FOV higher than default, gets worse the higher the FOV. Happens regardless of aspect ratio. At high resolutions I've also noticed that the line completely disappears. Please, Mojang... please look at this very annoying bug! #MakeFishingGreatAgain

Those screenshots are not made in Vanilla Minecraft. I suspect it's OptiFine or similar. Please only test bugs and attach screenshots from Vanilla Minecraft.

There you go - takes 30 seconds to switch to a completely vanilla profile and see that this bug is not an OptiFine bug. Screenshot uploaded. 

This has been a problem in the game for 7 going on 8 years now. It's not an OptiFine issue.

Affects 20w18a

Also just checked some additional numbers. The fishing line model is disconnected at FOV's 46 and higher (although the ones from 46-50 are barely noticeable but still there).

Can confirm in 21w05b.

Blocked from testing in 21w11a, by MC-219849

Code analysis (based on 1.16.4, but the same idea should apply to more recent snapshots):

The logic for determining where the hook should be looks like this:

if ((this.renderManager.options == null || this.renderManager.options.thirdPersonView <= 0) && playerentity == Minecraft.getInstance().player) {
	double fov = this.renderManager.options.fov;
	// ... compute hand position for first person ...
} else {
	// ... compute hand position for third person ...
}

However, it should look something like this:

if (this.renderManager.options != null && this.renderManager.options.thirdPersonView <= 0 && playerentity == Minecraft.getInstance().player) {
	double fov = this.renderManager.options.fov * playerentity.getFovModifier();
	// ... render first person ...
} else {
	// ... render third person ...
}

Note that this also fixes a null check; if this.renderManager.options is null, then accessing this.renderManager.options.fov won't work. (I don't know if renderManager.options will ever be null though). It also isn't entirely accurate to use playerentity.getFovModifier either, as that doesn't handle the gradual transitions that are applied to the hand FOV in GameRenderer; there is a function there that computes the appropriate FOV that would be better to use.

They fixed it guys, at least when not running.

it's also broken when using a different aspect ratio than 16:9

This issue seems to be fixed in vanilla 1.17.1, no idea why its tagged as affected in 1.17.1

Examples of what is still causes this in 1.17.1:

• anything other than 16:9

• sprinting

• animation between sneaking and not sneaking

• Speed and Slowness effects
  Also, surely there's a way to actually fix this properly once and for all, right? Out of all of these cases, only the aspect ratio changes where the fishing rod item is displayed, but the client already knows that. Otherwise, only connecting a line from that position to whatever position the bobber is in should be needed. And for other players, it already works correctly.

See this comment for more info; it ignores things that change the FOV modifier, but does look at the FOV option value. Judging only from the duplicates, there was also once an issue where it ignored the FOV option value, but I don't know when/if that changed (and I don't want to separate out that behavior into a new issue because I'm not 100% sure it did change).

The sneaking animation is its own issue (MC-148088). I think the aspect ratio problem should also be created as a separate issue (that should be linked to this one).

Oh, I see. So this bug is still present, it is just fixed for the FOV slider.