mojira.dev
MC-6579

Fishing line ignores FOV modifiers

This is especially seen when the fov is high but it is true any time the fov is changed: running, flying, potion effects.

To see for yourself just cast a line in your favorite lake and run.

I am mostly certain that this has not been addressed before; all other fishing rod problems were much more different than this.

Linked issues

MC-30563 Fishing line does not connect to rod on FOV's greater than default MC-41817 FOV-Bug while fishing MC-83425 Fishing line not conected to fishing rod for FOV != 70 MC-99891 Fishing Rod line not attached to poll at any FoV other than 90 MC-102779 Fishing rod string not attached. MC-109882 Fishing rod line isn't well positioned while flying. MC-136191 Fishing rod line does not connect with fishing rod MC-148083 The fishing line is not connected to the fishing pole MC-151305 crooked strip on a fishing pole MC-151419 when you fish, the texture of the fishing pole is not visible (where the fishing line contacts the stick) MC-152637 Fishing rod line not connecting with rod in first person MC-155030 Fishing line does not connect to fishing pole in first person MC-222293 Fishing Rod Visual Glitches- pt. 2 MC-230460 fishing line not connected to fining rod MC-253540 Fishing line rendering is dependant on aspect ratio MC-263503 Fishing rod string out of placement

Attachments

Comments

Pixelgraph

Confirmed and a very annoying bug.

Vytenis Narušis

Still a problem in 13w04a

Tails

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

Grant Cafasso

Why yes it is.

Sand Lantern

This bug is still present in release 1.7.2

Itouch2

Confirmed for 1.7.5 and 14w11b

Itouch2

Confirmed for 14w17a

Itouch2

Confirmed for 14w25b.

Andrew McCluskey

Confirmed for 14w29a and b.

shufboyardee

Is this fixed in 33b, with the other fishing rod fixes?

Vytenis Narušis

Not fixed in 14w33c

[Mod] Neko

Not fixed in 16w43a.

JUE13

Confirmed for 17w17a

Selebrator

Confirmed for 17w43b

Jack McKalling

Confirmed for 18w48a

Jack McKalling

Confirmed for 18w48b

Jack McKalling

Confirmed for 18w49a

Jack McKalling

Confirmed for 18w50a

Jack McKalling

Confirmed for 19w02a

Jack McKalling

Confirmed for 19w03a

Jack McKalling

Confirmed for 19w03b

Jack McKalling

Confirmed for 19w03c

Jack McKalling

Comfirmed for 19w04a

Jack McKalling

Confirmed for 19w04b and 19w05a

Jack McKalling

Confirmed for 19w06a

Jack McKalling

Confirmed for 19w07a

Jack McKalling

Confirmed for 19w09a

Jack McKalling

Confirmed for 19w11a

Jack McKalling

Confirmed for 19w11b

Jack McKalling

Confirmed for 19w12a

Jack McKalling

Confirmed for 19w12b

Jack McKalling

Confirmed for 19w13a

Jack McKalling

Confirmed for 19w13b

Jack McKalling

Confirmed for 19w14a

Jack McKalling

Confirmed for 19w14b

Jack McKalling

Confirmed for 1.14 pre-1

violine1101

As of 1.14-pre2, the fishing rod seems to only connect properly with FOV set to 30.

Jack McKalling

Confirmed for 1.14 pre-3

Jack McKalling

Confirmed for 1.14 pre-4

Jack McKalling

Confirmed for 1.14 pre-5

Jack McKalling

Confirmed for 1.14

Jack McKalling

Confirmed for 1.14.1 pre-1

Jack McKalling

Confirmed for 1.14.1 pre-2

Jack McKalling

Confirmed for 1.14.1

Jfarf_Gl

Confirmed for 1.14.2 pre-3. In first person, the fishing rod's line doesn't fully connect with the rod itself. This is not just an issue with my client, other colleagues have reported the same bug. This happens regardless of resource packs being installed or not. The rod's line does fully connect in third person. See the attached screenshots. 

Jfarf_Gl
[media]
Wild Katz

Confirmed for 1.14.3 pre-1

 

Fix this already, it bugs my OCD xD

Wild Katz

1.14.4

Fishing line doesn't connect to the fishing rod. The gap is kinda smaller right now, but still not correctly connected.

TheBoy358

Confirmed in 19w45b.

Jfarf_Gl

I would love it this were to be assigned and looked at. It's such an immersion breaking bug for something that pretty much everyone on the Java edition does - changes FOV. 

christofin

Attached some screenshots. Line becomes detached at any FOV higher than default, gets worse the higher the FOV. Happens regardless of aspect ratio. At high resolutions I've also noticed that the line completely disappears. Please, Mojang... please look at this very annoying bug! #MakeFishingGreatAgain

FaRo1

Those screenshots are not made in Vanilla Minecraft. I suspect it's OptiFine or similar. Please only test bugs and attach screenshots from Vanilla Minecraft.

christofin

There you go - takes 30 seconds to switch to a completely vanilla profile and see that this bug is not an OptiFine bug. Screenshot uploaded. 

 

This has been a problem in the game for 7 going on 8 years now. It's not an OptiFine issue.

ProPork

Affects 20w18a

ProPork

Also just checked some additional numbers. The fishing line model is disconnected at FOV's 46 and higher (although the ones from 46-50 are barely noticeable but still there).

Avoma

Can confirm in 21w05b.

Jack McKalling

Blocked from testing in 21w11a, by MC-219849

pokechu22

Code analysis (based on 1.16.4, but the same idea should apply to more recent snapshots):

The logic for determining where the hook should be looks like this:

if ((this.renderManager.options == null || this.renderManager.options.thirdPersonView <= 0) && playerentity == Minecraft.getInstance().player) {
	double fov = this.renderManager.options.fov;
	// ... compute hand position for first person ...
} else {
	// ... compute hand position for third person ...
}

However, it should look something like this:

if (this.renderManager.options != null && this.renderManager.options.thirdPersonView <= 0 && playerentity == Minecraft.getInstance().player) {
	double fov = this.renderManager.options.fov * playerentity.getFovModifier();
	// ... render first person ...
} else {
	// ... render third person ...
}

Note that this also fixes a null check; if this.renderManager.options is null, then accessing this.renderManager.options.fov won't work. (I don't know if renderManager.options will ever be null though). It also isn't entirely accurate to use playerentity.getFovModifier either, as that doesn't handle the gradual transitions that are applied to the hand FOV in GameRenderer; there is a function there that computes the appropriate FOV that would be better to use.

PiCO109
[media]

They fixed it guys, at least when not running.

[media]
fayer3

it's also broken when using a different aspect ratio than 16:9

[media]
CheesyTheArtist

This issue seems to be fixed in vanilla 1.17.1, no idea why its tagged as affected in 1.17.1

[media]
FaRo1

Examples of what is still causes this in 1.17.1:

  • anything other than 16:9

  • sprinting

  • animation between sneaking and not sneaking

  • Speed and Slowness effects
    Also, surely there's a way to actually fix this properly once and for all, right? Out of all of these cases, only the aspect ratio changes where the fishing rod item is displayed, but the client already knows that. Otherwise, only connecting a line from that position to whatever position the bobber is in should be needed. And for other players, it already works correctly.

pokechu22

See this comment for more info; it ignores things that change the FOV modifier, but does look at the FOV option value. Judging only from the duplicates, there was also once an issue where it ignored the FOV option value, but I don't know when/if that changed (and I don't want to separate out that behavior into a new issue because I'm not 100% sure it did change).

The sneaking animation is its own issue (MC-148088). I think the aspect ratio problem should also be created as a separate issue (that should be linked to this one).

ampolive

Oh, I see. So this bug is still present, it is just fixed for the FOV slider.

Avoma

Can confirm in 1.18.2.

Avoma

Can confirm in 1.19.

Avoma

Can confirm in 1.19.2.

JUE13

Can confirm in 22w42a

Mac Rat

Confirmed in 1.20

Grant Cafasso

(Unassigned)

Confirmed

Platform

Low

Camera, Items

FOV, fishing-line, fishing_rod

Snapshot 13w01b, Snapshot 13w04a, Minecraft 1.5, Minecraft 1.5.2, Minecraft 1.6.1, ..., 1.20.2, 1.20.4, 1.21, 1.21.1, 24w39a

Minecraft 16w43a

Retrieved