mojira.dev
MC-69696

Fire animation is dark for spiders, endermen and phantoms

The bug

When a spider, enderman or phantom is on fire, the mob itself is bright but the fire animation uses the same brightness as the surroundings (causing it to appear dark in dark places). All of these mobs use multiple layers for glowing eyes.

To reproduce

Set a spider, enderman or phantom on fire in a dark area (e.g. night time), and compare the flame animation with that of any other mob.

Linked issues

Attachments

Comments 14

Other mobs will burn and emit light even if it is light out

You are correct, but no need to be rude. We get tons of duplicate issues, some will get resolved wrong by accident.

Confirmed for 1.8. It seems that the Spider itself is bright but the fire animation is dark.

Confirmed for 1.8.1.

Confirmed for 1.10.2.

4 more comments

I was able to fix this for spiders in a forge 1.12 mod by using reflection to remove the spider eye render layer from the spider renderer's render layer list.  Doing so also fixed MC-84404.

Update: after replacing the spider eye layer with a custom version, I've come to the conclusion that the fire render issue is due (as one may expect) to an issue with the lightmap settings upon leaving the spider eye layer rendering method.  I've fixed this in my mod by simply saving the lightmap texture coordinates to method-local variables, doing the render, and then setting them back to what they were, instead of attempting to recalculate them as is done "currently", "currently" being 1.12.2 in my case.

 

Edit: My solutions for spiders and endermen can be found below, but they also include a non-optimal workaround for team glow color (MC-84404).  The relevant part for this issue is strictly the lightmap-related code (what has been removed, changed, and added for lightmap-related functions):

https://github.com/Laike-Endaril/Dynamic-Stealth/blob/1c65272fdd96b7c38e43126d02f77ccaf26e8d21/src/main/java/com/fantasticsource/dynamicstealth/client/layeredits/LayerSpiderEyesEdit.java

...

https://github.com/Laike-Endaril/Dynamic-Stealth/blob/1c65272fdd96b7c38e43126d02f77ccaf26e8d21/src/main/java/com/fantasticsource/dynamicstealth/client/layeredits/LayerEndermanEyesEdit.java

Confirmed in 19w34a

Fixed in some 1.15 snapshot.

Dylan Beswick

(Unassigned)

Confirmed

Lighting, Rendering, Textures and models

cave-spider, enderman, fire, flame, light, light-level, phantom, spider, texture

Minecraft 1.8-pre1, Minecraft 1.8-pre2, Minecraft 1.8, Minecraft 1.10.2, Minecraft 16w39a, ..., Minecraft 18w50a, Minecraft 1.14 Pre-Release 5, 1.14.4, 19w34a, 19w37a

19w45b

Retrieved