Fall damage death messages don't show block player fall from correctly (ladders, vines, water)

Dinnerbone has confirmed that this is a bug. Note to Mods: Don't erase this until fixed.

Do we erase tickets ?

Sorry. Worded that wrong. Don't close this ticket. 😛

edited the post

I don't recall confirming this is a bug. The "finished off" text is only for when you fell previously, "x fell from a high place and was finished off by y" and not just plain old "x was finished off by y", so that part is working as intended. As for /kill on vines/ladders, that's just a special case of how /kill works. Won't fix for this snapshot, we'll see for next.

Probably a result of the changes Jeb had to make to fix MC-8647.

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue.

Keep in mind that the "Resolved"-Status on this ticket just means "Answered", and that we are waiting for further information on whether this issue still exists or not. We will reopen it as soon as the requested information has been deliviered.

Yes, it still seems to be an issue in the current Minecraft version. I have not seen death messages for "<player> fell off a ladder" and "<player> fell off some vines" as well as some others do not appear to display in the game. These are the death messages in the EN_US.lang file in the 1.8.jar:

death.fell.accident.ladder=%1$s fell off a ladder
death.fell.accident.vines=%1$s fell off some vines

Updated, thanks.

Confirmed for 1.8.8

Still in 1.10

Please link this post in the description.
All names are based on MCP 9.30

Why this happens
This happens because the check being done in net.minecraft.util.CombatTracker.calculateFallSuffix() looks for the block the player occupies when he dies. Since you aren't at the ladder anymore when you die, the messages will never appear.

How to fix
I came up with a simple fix, although it isn't just one line. In order to fix this problem, you need a variable that keeps track of the climbable Block the Entity occupied before it started falling (in this case fallSuffixBlock).

Changes/additions I made to net.minecraft.util.CombatTracker

net.minecraft.util.CombatTracker

/*
 * keeps track of the block that the entity was climbing on.
 */
private Block fallSuffixBlock;

public void calculateFallSuffix()
{
	this.resetFallSuffix();

	if (this.fallSuffixBlock != null)
	{

		if (this.fallSuffixBlock == Blocks.LADDER)
		{
			this.fallSuffix = "ladder";
		}
		else if (this.fallSuffixBlock == Blocks.VINE)
		{
			this.fallSuffix = "vines";
		}
		else if (this.fallSuffixBlock == Blocks.WATER || this.fallSuffixBlock == Blocks.FLOWING_WATER)
		{
			this.fallSuffix = "water";
		}

		this.setFallSuffixBlock(null);
	}
}

public void setFallSuffixBlock(Block blockIn)
{
	this.fallSuffixBlock = blockIn;
}

Then I made a simple condition in net.minecraft.entity.EntityLivingBase.onUpdate() to keep it updated.

net.minecraft.entity.EntityLivingBase.onUpdate()

//... added at line 2237
if (this.isOnLadder()) //Also true if player is on vines, therefore need to check for actual Block.
{
	this.getCombatTracker().setFallSuffixBlock(this.worldObj.getBlockState(new BlockPos(this.posX, this.getEntityBoundingBox().minY, this.posZ)).getBlock());
}
else if (this.isInWater())
{
	this.getCombatTracker().setFallSuffixBlock(Blocks.WATER);
}
//reset fallSuffixBlock if entity is on solid ground again.
else if (this.onGround)
{
	this.getCombatTracker().setFallSuffixBlock(null);
}
//...

Also can confirm for 1.10.2

Can confirm for 16w32a.

Can confirm for 1.11.2

Removed not existing death messages from description

Can confirm for 17w43a/b

@unknown ticket is yours now.

Can anyone confirm for 1.13?

Can confirm for 1.13.1 ...

Afaik there were messages like

"<player> was doomed to fall by <mob>"

"<player> was doomed to fall by / walked into a cactus/drowned whilst fighting <mob>" only seems to appear when the time between the mob damage and death is very, very short, like if a zombie hits you into a cactus while you are on 2.5 hearts only then will that message display

Confirmed for 1.14 Pre-Release 4.

This video was uploaded on the 1st of February 2013 and recorded shortly before, on a server that was either on the latest version or even a pretty recent snapshot at that point: https://www.youtube.com/watch?v=YbuWmY0p6a4
It shows multiple death messages listed here, including "was knocked off a high place by <player>". So apparently the version that broke it came out in late 2012 or early 2013.

According to an unofficial, fan-made Mindcrack wiki, the server always used the latest snapshot since the end of 2012, so this video should have been recorded in 13w10b: https://youtu.be/L8HHrijSwRg?t=508

It shows one of these very descriptive death messages, even though an earlier version is listed here.

I just tested it in 1.6.2 and got "was doomed to fall by zombie". In 1.14.2-pre3 I get "fell from a high place". In 1.4.7 it's also "fell from a high place". I didn't try old snapshots, because they aren't in the launcher, so it's complicated to get them. Something is very strange about the versions marked in this report.

This ticket only covers fall damage caused by falling off blocks, it does not cover being hit by mobs (or players) and then dying of fall damage. There's probably another ticket about those cases.

This video was uploaded on 2019-08-19, so it was recorded about 70 days after the release of 1.6.2 and before the next snapshot (13w36a), so Etho was very likely playing in 1.6.2: https://youtu.be/Etf9CJxvKeM?t=1296

He got the death message "<player> fell off a ladder", even though that is in the version list of this report. @unknown, do you still remember how you tested it back then? It was apparently wrong.

@unknown In this video (https://www.youtube.com/watch?v=YbuWmY0p6a4) which you commented above, Etho played in 13w04a. In 13w02a-13w04a, falling death messages worked in an interesting way:

There were two types of messages, " [player] 'first' " and " [player] 'first' and 'last' ".

<first> could be:

• fell [off a ladder/off some vines/out of the water/fell from a high place]

• was [shot/pummeled/blown/fireballed/knocked] [off a ladder/off some vines/out of the water/from a high place]

• was [shot/pummeled/blown/fireballed/knocked] [off a ladder/off some vines/out of the water/from a high place] by [player/mob]

<last> could be:

• into a pool of lava

• fell out of the world

• into a patch of fire

• into a patch of cacti

• got finished off by [player/mob]

• got finished off by [player/mob] using [item]

• got finished off using [item]

I've done the math. There were 352 different death messages.

(Well, technically there were 416 because the verb "blown" existed twice in en_US.lang.)