Fall damage death messages don't show block player fall from correctly (ladders, vines, water)

Probably a result of the changes Jeb had to make to fix MC-8647.

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue.

Keep in mind that the "Resolved"-Status on this ticket just means "Answered", and that we are waiting for further information on whether this issue still exists or not. We will reopen it as soon as the requested information has been deliviered.

Yes, it still seems to be an issue in the current Minecraft version. I have not seen death messages for "<player> fell off a ladder" and "<player> fell off some vines" as well as some others do not appear to display in the game. These are the death messages in the EN_US.lang file in the 1.8.jar:

death.fell.accident.ladder=%1$s fell off a ladder
death.fell.accident.vines=%1$s fell off some vines

Updated, thanks.

Confirmed for 1.8.8

Still in 1.10

Please link this post in the description.
All names are based on MCP 9.30

Why this happens
This happens because the check being done in net.minecraft.util.CombatTracker.calculateFallSuffix() looks for the block the player occupies when he dies. Since you aren't at the ladder anymore when you die, the messages will never appear.

How to fix
I came up with a simple fix, although it isn't just one line. In order to fix this problem, you need a variable that keeps track of the climbable Block the Entity occupied before it started falling (in this case fallSuffixBlock).

Changes/additions I made to net.minecraft.util.CombatTracker

net.minecraft.util.CombatTracker

/*
 * keeps track of the block that the entity was climbing on.
 */
private Block fallSuffixBlock;

public void calculateFallSuffix()
{
	this.resetFallSuffix();

	if (this.fallSuffixBlock != null)
	{

		if (this.fallSuffixBlock == Blocks.LADDER)
		{
			this.fallSuffix = "ladder";
		}
		else if (this.fallSuffixBlock == Blocks.VINE)
		{
			this.fallSuffix = "vines";
		}
		else if (this.fallSuffixBlock == Blocks.WATER || this.fallSuffixBlock == Blocks.FLOWING_WATER)
		{
			this.fallSuffix = "water";
		}

		this.setFallSuffixBlock(null);
	}
}

public void setFallSuffixBlock(Block blockIn)
{
	this.fallSuffixBlock = blockIn;
}

Then I made a simple condition in net.minecraft.entity.EntityLivingBase.onUpdate() to keep it updated.

net.minecraft.entity.EntityLivingBase.onUpdate()

//... added at line 2237
if (this.isOnLadder()) //Also true if player is on vines, therefore need to check for actual Block.
{
	this.getCombatTracker().setFallSuffixBlock(this.worldObj.getBlockState(new BlockPos(this.posX, this.getEntityBoundingBox().minY, this.posZ)).getBlock());
}
else if (this.isInWater())
{
	this.getCombatTracker().setFallSuffixBlock(Blocks.WATER);
}
//reset fallSuffixBlock if entity is on solid ground again.
else if (this.onGround)
{
	this.getCombatTracker().setFallSuffixBlock(null);
}
//...

Also can confirm for 1.10.2

Can confirm for 16w32a.

Can confirm for 1.11.2

Removed not existing death messages from description

Can confirm for 17w43a/b

@unknown ticket is yours now.

Can anyone confirm for 1.13?

Can confirm for 1.13.1 ...

Afaik there were messages like

"<player> was doomed to fall by <mob>"

"<player> was doomed to fall by / walked into a cactus/drowned whilst fighting <mob>" only seems to appear when the time between the mob damage and death is very, very short, like if a zombie hits you into a cactus while you are on 2.5 hearts only then will that message display

Confirmed for 1.14 Pre-Release 4.