mojira.dev
MC-74764

Particle "largeexplode", "hugeexplosion" and “sweepattack” not showing when using the front view (twice F5)

What I expected to happen was:
I was using the "front view mode" (pressing F5 2 times) and I did this: /particle largeexplode ~ ~ ~5 2 2 2 1 25

What actually happened was:
The particles did not show up, but they did in 3rd person view and first person view

Steps to Reproduce:
1. Press F5 2 times
2. execute a /particle command with the particle largeexplode*

*Some other particles does not show up, like hugeexplosion

Look at attached files to see what I mean by front view

Code analysis

Based on 1.11 decompiled using MCP 9.35 rc1

It looks like all particles which override the method net.minecraft.client.particle.Particle.getFXLayer() to return 3 and are therefor rendered by the method net.minecraft.client.particle.ParticleManager.renderLitParticles(Entity, float) are not correctly rotated when the player is using the front view unless they are not rendering something themself like mobappearance which renders an entity.

It seems like this can be fixed by having the method net.minecraft.client.particle.ParticleManager.renderLitParticles(Entity, float) call the methods ActiveRenderInfo.getRotationX();, ActiveRenderInfo.getRotationZ();, ... instead of calculating the values itself, just like the method net.minecraft.client.particle.ParticleManager.renderParticles(Entity, float) does it.

Related issues

Attachments

Comments

migrated
[media][media][media][media][media]
migrated

Regression of MC-4286

marcono1234

Confirmed for

  • 16w06a

Please include "hugeexplosion" in the title as well

migrated

Can confirm for 1.12

Charcoal

Erik Broes

Confirmed

Minecraft 1.8, Minecraft 1.8.1, Minecraft 1.8.8, Minecraft 15w49b, Minecraft 1.8.9, ..., Minecraft 1.12.2, Minecraft 17w45b, Minecraft 18w02a, Minecraft 1.13, Minecraft 18w30a

Minecraft 18w30b

Retrieved