mojira.dev
MC-83590

Armor attributes list can be too long

When you add attributes to a piece of armor (i.e. genericAttackDamage), when you mouse over the armor there is a huge list saying what attributes it gives if put in the leg slot, chest slot, head slot, main hand, etc.

Linked issues

Attachments

Comments 11

Judging from a recent reddit post, seems true. It looks like per-slot attributes were being implemented, but the general case wasn't specified. As such, when attributes are displayed, it runs through each slot and lists the general stats, instead of defaulting to the original behavior.

You have to set a value for the Slot tag

The issue here is that you end up with duplicate modifier UUIDs on the player. One overrides the other, and we end up in a bad spot.
In the next snapshot you have

Slot: "mainhand"

(and other slots) on the modifier element. Please specify a different UUID for mainhand/offhand, and you should see the issue go away.

comment by @unknown on MC-87050

You are correct that the bug goes away when adding the Slot tag, however the tag isn't required, and the behavior should be correct without it as well. It doesn't make sense to have to specify the attributes for every possible slot if they are all the same.

Can confirm that this is an issue in 20w51a.

Can confirm in 21w05a. Feel free to use the following command to reproduce this issue:

/give @p minecraft:diamond_boots{AttributeModifiers:[{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"mainhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"offhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"head",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"chest",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"legs",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"feet",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.armor_toughness",Name:"generic.armor_toughness",Slot:"mainhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.armor_toughness",Name:"generic.armor_toughness",Slot:"offhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.armor_toughness",Name:"generic.armor_toughness",Slot:"head",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.armor_toughness",Name:"generic.armor_toughness",Slot:"chest",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.armor_toughness",Name:"generic.armor_toughness",Slot:"legs",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.armor_toughness",Name:"generic.armor_toughness",Slot:"feet",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"mainhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"offhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"head",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"chest",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"legs",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"feet",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_knockback",Name:"generic.attack_knockback",Slot:"mainhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_knockback",Name:"generic.attack_knockback",Slot:"offhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_knockback",Name:"generic.attack_knockback",Slot:"head",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_knockback",Name:"generic.attack_knockback",Slot:"chest",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_knockback",Name:"generic.attack_knockback",Slot:"legs",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_knockback",Name:"generic.attack_knockback",Slot:"feet",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"mainhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"offhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"head",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"chest",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"legs",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"feet",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"mainhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"offhand",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"head",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"chest",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"legs",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]},{AttributeName:"generic.attack_speed",Name:"generic.attack_speed",Slot:"feet",Amount:1,Operation:0,UUID:[I;1046560287,1027925671,1072191473,1311754640]}]} 1
1 more comments

Can confirm in 21w07a.

Can confirm in 1.16.5 and 21w08b.

Can confirm in 21w11a.

Can confirm in 21w17a.

Can confirm in 1.17.

Cassidy Young

slicedlime

Confirmed

(Unassigned)

Minecraft 15w31a, Minecraft 15w34d, Minecraft 15w35b, Minecraft 15w44b, Minecraft 16w04a, ..., 21w07a, 21w08b, 21w11a, 21w17a, 1.17

24w20a

Retrieved