[MC-9473] Unnecessary delay of "Done" button in the resource pack selection menu

After doing nothing in the Resource Packs menu and then pressing "Done" to leave the menu, there's an absolutely unnecessary delay of up to several seconds. Pressing "Esc" allows you to leave the menu too without any delay.

Easy steps to reproduce:
1.) Open the Resource Packs menu
2.) Press "Done" to leave the menu.

The delay time seems to depend on the resolution of the selected Resource Pack(s), pressing "Done" after selecting a 256x256 pack freezes the game for about 20 seconds, after selecting a 16x16 pack it's only 1-2 seconds.

Linked issues

is duplicated by 1

MC-60666 Clicking "Done" on the Resource Packs screen causes a freeze even when there is no change Resolved

Comments 27

Manuel 2013-02-09T12:37:06Z

confirmed

Anon Ymus 2013-02-09T15:02:57Z

Confirmed.

Callum Evans 2013-02-15T12:29:06Z

Confirmed.

Самуил 2013-02-15T14:17:34Z

Confirmed.

_zombiehunter 2013-02-15T14:41:09Z

Woohoo, Dinnerbone fixed that old and annoying bug!
Thanks a lot 🙂

17 more comments

juanminecraf 2013-02-17T15:37:52Z

and as game

Pedro Augusto 2013-02-17T19:55:45Z

how do I dowload

Callum Evans 2013-02-17T22:58:39Z

This fix should be in 13w08a as Dinnerbone fixed the bug a day after 13w07a was released.

_zombiehunter 2013-09-05T16:38:42Z

This bug seems to be back in 13w36a !!!
Could someone please confirm and reopen this?

Anon Ymus 2013-09-05T16:42:16Z

No, when you press the done button, it now combines all your resource packs. Pressing escape cancels it, so there is nothing to be done and therefore, no delay.

Самуил 2013-09-05T16:53:27Z

Confirmed in 13w36a.

_zombiehunter 2013-09-05T19:28:17Z

@Anon Ymus:
When I don't do any changes to the list, the game has nothing to combine. It's practically the same bug as we had with the old menu before 13w09a.
Just open the resource pack selection menu, select some packs, press done (delay because Minecraft is combining the packs and applying them to the game). Open the menu again and press done without changing the list. It's the same delay again even though all packs are already combined and applied to the game. That's exactly the described bug, so would anyone be so kind and reopen this?

_zombiehunter 2013-09-05T19:32:51Z

Thanks 🙂

ipyronic 2013-10-25T15:36:28Z

Wouldn't it be re-applying your selected resource packs?
You selected "Done", so it should be applying them regardless of whether you already have those ones applied from before. That way it will load changes that have occurred if you edited a resource pack while you were using it o.o If it just checks and sees "Oh hey, you already had these before" and then says "I'm not going to do anything", then you will have to switch to another pack and then switch back if you want to make your resource pack file changes work. That's potentially double the lag. If you know you didn't change anything, then you should press Esc or they should add a Cancel button. A Cancel button would be nice~

Edit: Or maybe make a Re-Apply button and make the Done button only apply when the list selections are altered.

_zombiehunter 2013-10-25T17:24:14Z

@iPyronic:
We have "F3+T" for re-applying resource packs. The delay of the Done button in the resouce pack menu is just annoying if you want to check what resource packs are applied to the game without chaning them.

Itouch2 2014-03-08T17:48:15Z

Still in 08a and 10c

Itouch2 2014-03-16T17:30:13Z

Confirmed for 14w11b

Itouch2 2014-04-24T17:42:28Z

Confirmed for 14w17a

Itouch2 2014-04-30T11:59:47Z

Confirmed for 14w18a

Itouch2 2014-05-06T19:40:10Z

Confirmed for 14w18b.

Itouch2 2014-05-08T15:17:06Z

Confirmed for 14w19a.

Sterling Shores 2014-06-19T20:18:33Z

The delay happens because when you press "Done", the client is loading any resource packs that you have selected, even the Default pack. The higher resolution the resource pack is, the longer the delay is.

_zombiehunter 2014-06-19T20:27:30Z

@Sterling Shores:
Please read the description of this ticket, especially the part with the Esc button ...
There's no need to load anything when you don't change any setting.

Mog (Ryan Holtz) 2014-07-10T08:22:24Z

The delay is because you're using a huge resource pack and the game needs to re-stitch all textures and re-process all models when you load a resource pack. Bug is invalid.

Oh, and Zombie Hunter, you mean the part in the bug where he says that pressing Escape doesn't give any delay, specifically because it's NOT reloading anything? Sounds like you're the one who needs to re-read the bug.

_zombiehunter 2014-07-10T10:58:41Z

@Mog:
"After doing nothing in the Resource Packs menu and then pressing "Done" to leave the menu, there's an absolutely unnecessary delay of up to several seconds. Pressing "Esc" allows you to leave the menu too without any delay."
I think that's a clear description of the problem, if you don't change any setting, why should the game load or re-load anything? If you just want to look up which Resource Packs are selected and then leave the menu, a delay of several seconds can be quite annoying ... and yes, I'm aware that re-stitching the textures causes the delay!

_zombiehunter 2014-07-10T10:59:06Z

Oh, looks like Dinnerbone fixed it. Thx 🙂

kazblox 2014-07-10T14:25:02Z

It looks like Dinnerbone is using multi-threading to skip the long delay for next snapshot!

🙂