mojira.dev
MC-95901

Always able to use sword sweep attack while walking

The bug

The sword "special attack" will work, even when moving, as long as the attack meter is full.

@unknown:
More MC combat shenanigans... Crit and knockback attack types are now separate, and there will be a third type if you move slowly

Source

Code analysis

Based on 1.11.2 decompiled using MCP 9.35 rc1

The method net.minecraft.entity.player.EntityPlayer.attackTargetEntityWithCurrentItem(Entity) has besides other ones the following condition to perform a sweep attack:

this.distanceWalkedModified - this.prevDistanceWalkedModified < this.getAIMoveSpeed()

The problem seems to be that for the server most of the time this.distanceWalkedModified and this.prevDistanceWalkedModified have the same value. Maybe because the client sends packets with its position instead of its motion and therefor this method is not called when the player walks server-side.

Attachments

Comments 10

Is this still an issue in the latest snapshot 16w44a? If so please update the affected versions.

This is an automated comment on any open or reopened issue with out-of-date affected versions.

Confirmed for 1.13.1.

Can confirm in 20w49a.

Can confirm in 21w05b.

Can confirm in 21w06a.

Can confirm in 21w07a.

Can confirm in 1.16.5 and 21w08b.

Can confirm in 21w11a.

Markus Dam

(Unassigned)

Confirmed

(Unassigned)

attack, movementSpeed, sweepAttack

Minecraft 16w03a, Minecraft 1.11.2, Minecraft 1.12.2, Minecraft 18w05a, Minecraft 1.13.1, ..., 21w06a, 21w07a, 21w08b, 21w11a, 1.21

Retrieved