mojira.dev
MC-97507

Using item which modifies the held item shows "Gear equips" subtitle

The bug

In some cases, like when picking up a flower from a flower pot (in Survival or Creative) or throwing an ender pearl, snowball or egg in Survival, the subtitle "Gear equipped" gets shown after the correct one.

Code analysis

Code analysis by @unknown can be found in this comment.

Related issues

MC-99558 custom potion says "gear equipped" on subtitles MC-101162 "Gear Equipped" sound plays after eating MC-118334 After eating subtitles will show "Gear Equipped" MC-143856 Thrown items play the "gear equipped" sound along with the thrown sound MC-154373 Berry sound MC-154450 After eating, Subtitles say gear equips MC-158399 Uncorrect subtitle when catching fish with a water bucket. MC-161228 subtitles MC-164975 Minecart Rolls & Gear Equips MC-172046 "Gear equips" subtitle when consuming an item MC-172588 when you eat sweet berries there is a subtitle that say's 'gear equips' even if you don't do anything related to gear MC-185233 "Gear Equips" subtitle shows when eating MC-185274 Subtitles are still showing ''Gear equips'' when eating in snapshot 20w21a or newer. MC-186194 Eating without emptying that slot will still produce "Gear Equips" subtitle

Attachments

Comments

migrated
[media][media][media][media][media]
kumasasa

Cannot confirm, see screenshot.

FaRo1

I almost forgot... I'll add two screenshots now.

FaRo1

Right after throwing a splash potion of instant health 2 and right after eating rotten flesh. Sorry for the texture pack, should I remove it and make new pictures? There are no text files in the ressource pack.

migrated

Please make a new screenshot without all those sounds, I can see bottle smashes just fine

FaRo1

There you have it. No noise, same result. Yes, it tells me the correct sounds, but also "Gear equiped".

migrated

I see this working now in -pre3 ("bottle thrown" for both splash and lingering pots)

JUE13

Confirmed for 1.9-pre3 with Survival mode.

FaRo1

Adjusted title for pre3. At least it got a bit better. 😉

marcono1234

Confirmed for

  • 1.9-pre3 but only for Survival mode, please mention that in the description

FaRo1

Done.

FaRo1

Should I also do something less stupid with the description than it's now?

shufboyardee

Affects 1.9.

marcono1234

Please link to this comment in the description

The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.

The reason why this happens is that whenever the net.minecraft.entity.EntityLivingBase.setHeldItem(EnumHand, ItemStack) method is called this sound will be played. Currently this method is called for changing the stack count which is probably not needed as modifying the stack count field of the item stack should work. Another problem is that often this method is called before testing if the stack count is 0 after using the item. (Looks like this is fixed for 16w33a)

See also this comment

FaRo1

Confirmed for 1.9.4 and 16w21b.

FaRo1

Confirmed for 1.10-pre1.

FaRo1

Half fixed in 1.10-pre2, eating doesn't have that subtitle anymore, but throwing a splash potion.
@unknown Still the same or did something change?

marcono1234

It looks like it is still the same in 1.10, however in 16w33a the part "Another problem is that often this method is called before testing if the stack count is 0 after using the item." is not the case anymore, the rest appears to be the same. This means that you have to eat from a stack of at least two food items and you need to throw a splash potion from a stack of at least two potions (only possible using commands).

Action

Players hearing it

Using item

all

Using item on block

other players

migrated

I included this in MC-98316, please move any discussion there.

marcono1234

I wrote there now that it is probably a good idea to split the reports because the reasons are quite different. Can this be renamed to something like

Using item which modifies the held item shows "Gear equipped" subtitle
SunCat

When you get a plant out of the flower pot in an empty you get this sound, too. Should I create a new ticket?

migrated

Can still confirm for 16w39c, but had a load of tick lag during the test. So might be my problem still. :/

FaRo1

When you get a plant out of the flower pot in an empty you get this sound, too. Should I create a new ticket?

I don't think so. It modifies the held item from empty to flower. But interestingly it doesn't happen if you take items from an armor stand.

JUE13

Confirmed for 16w07a

I noticed that when I take a flower from a flower pot, there is no animation in the hotbar, but when I take the item from the armor stand, there is animation in the hotbar.

migrated

Affects 17w16b

FaRo1

I can no longer reproduce this with eating and throwing potions, only picking flowers from flower pots. Does someone know another way to reproduce this?

Asteraoth

Try throwing ender pearls, snowballs and eggs with an item stack more than one.

migrated

Affects 1.14.2.

muzikbike

Can confirm for 19w38b, can I request ownership?

FaRo1

No need, I just need to stop forgetting to update my reports. 😃

muzikbike

Affects 19w39a

migrated

Affects 19w44a

migrated

The player making the sound can't hear it (or see it in subtitles). Only surrounding players are affected, from my experience.

migrated

Confirmed in 20w13b

Humiebees

fixed

FaRo1

mgatland

Confirmed

Normal

Accessibility, Sound

Minecraft 1.9 Pre-Release 2, Minecraft 1.9 Pre-Release 3, Minecraft 1.9, Minecraft 1.9.1 Pre-Release 3, Minecraft 1.9.1, ..., 19w44a, 1.15.1, 1.15.2, 20w13b, 20w17a

Minecraft 1.9 Pre-Release 3, 20w21a, 20w27a

Retrieved