May 5th 2021 Nintendo Switch update error?

The “software update” was probably just the update screen popping up because his account had been signed out. You should be able to sign in the Nintendo account again to regain access to purchases made through it. Is the profile he uses on the Switch still linked to the same Nintendo online account? Were any settings in the Nintendo account changed?

Where I would sign in is only replaced by the Microsoft account sign in.
Nothing has changed with our Nintendo account, that image of the purchase is/was the last activity.

There was a software update toward the end of April 2021.
If the game was in sleep or suspended animation since then and was never exited from the game then it would never trigger the system up date.
I do remember actually turning it off yesterday via the power button long press and "Off" instead of sleep.
When my son grabbed it today, I almost guarantee that when he clicked on Minecraft image on the XMB to open the game, he was prompted to software update like every game I've seen does.  That issue is that he docks the Switch and it's in suspended sleep mode, so there was something that triggered this via a software issue.
I'm not sure what settings I'm am looking for in my "Nintendo account" that were changed because 1.) He doesn't/can't access it and 2.) I haven't either.

I'd provide another picture, but it still shows those two map packs locked.
So it is literally the same pic as the original attachment

Answer me this, explain and list reasons why the two map packs we bought my son would just stop working?
AND THEN we can trouble shoot from there. I literally just want these back unlocked, they were a gift for him he has been super excited and learning with it.

Why are comments getting deleted or not posted?

Todd: Your comments with the screenshots are being hidden by an automatic privacy filter, apparently because our bot thinks they contain personal login information. Sorry for the confusion. I can still see them.

Please understand that this is a bug tracker and not a support forum. We do not have the resources to provide technical support or engage in live conversation about an issue. For that, you may use our Community Support Discord for assistance and refer to this ticket (e.g. "I have reported this issue on Mojira as MCPE-XYZ.").

Please also understand that bug tacker staff like me are community volunteers and not Mojang employees, and we do not have access to any of your accounts. You can contact Mojang Support for account or payment issues.

I would like to help you if I can. Let me lay out what I am thinking:

• In order to make purchases in the marketplace, you must have been logged in to either a Microsoft account or a Nintendo Online account.

• The content you purchased is not accessible now because you are logged out.

• A Minecraft software update should not have logged you out, but maybe it did due to a bug.

• The last Minecraft software update was April 22 (see here).

• The Minecraft update pop-up screen is known to sometimes show when you are logged out unintentionally. I have experienced this myself, and that is why I guessed that that was what happened.

• When you say "late April update" I'm not sure if you mean when the update came on April 22nd (sometimes it shows up a day or two later), or the update screen erroneously appearing some time after that due to you getting logged out, or if you mean a Switch update message that may pertain the Switch firmware or other software you have installed.

• If you never used a Microsoft account to log in to Minecraft, then on the screen that comes up after you click "Sign In...", choose "Leave On Device". That should reconnect you to the Nintendo account login.

To respond to the "Community Support Discord" passing of the buck. I was on there and this is another problem. Each place I go to for help, be it Minecraft forums, Discord, Nintendo FAQs, Microsoft FAQs, etc. They combine to make a literal LOOP of where to find help.

To speak further on the troubleshooting front thank you for attempting to provide potential problems.
- Nintendo Online account was used to purchase the Minecoins, which I provided a screenshot of that transaction. Those were then used within the Marketplace in Minecraft to purchase these map packs.

["If you never used a Microsoft account to log in to Minecraft, then on the screen that comes up after you click "Sign In...", choose "Leave On Device". That should reconnect you to the Nintendo account login."]

That is an issue, it never defaults to the Nintendo account when I select Leave on Device. When starting up a fresh reboot there a "loading window" that appears for a brief less than a second. This doesn't not appear if I reattempt the Leave on Device option afterward, but will appear again after a fresh reboot.

Yes, late in April. I didn't want to quote the date of the update because just like you mentioned they may not trigger universally at the same moment due to many variables, like the ones I laid out in one of my previous messages.

Is this still an issue?

Cleaning up old tickets: This ticket had been set to 'Awaiting Response', but has not received a response from the reporter (~3 months+) so is being closed as Incomplete. If you feel this is still a valid issue then please comment, or create a new ticket following the Issue Guidelines which includes steps to reproduce the problem.

Quick Links:
📓 Bug Tracker Guidelines – 📧 Mojang Support
📓 Project Summary – ✍️ Feedback and Suggestions – 📖 Game Wiki