mojira.dev

Aidan T Wilson

Assigned

No issues.

Reported

MC-197569 Structures Generate Above Bedrock... Again. Duplicate MC-194953 Custom Biomes are not useable in Predicates Fixed

Comments

Is this still an open issue? It seems to be present in 21w18a, at least according to this ticket, but the last time anyone mentioned it or reported it was November of 2020 (7 months ago).

This bug (as far as I can tell) is related to the fact that the game does not check whether a block actually has a block state before modifying said block state, at least when placing features statically.

Interestingly, SlicedLime started working on correcting what I think is the same bug as this one in the following issue: MC-200009

 

Seems like my work here is done, at least until the fix comes out. At that point, I'll probably check if the bug is fixed for each individual feature type.

No, I'm not saying that. What I am saying is that, from a programmer's standpoint, it's probably better to plan for this type of thing in advance. If each type of configured_feature is made configurable, then they're going to need to make sure they have a system that only sets properties where they are needed. For example, it should simply not modify the block states when it detects that a block does not have them, and just place them normally. Of course, in this case, it isn't bothering to detect these things at all, which probably means that Mojang didn't add any checks for that - probably because they didn't predict that people would use different blocks for this type of thing. Unfortunately, that is not the case. People want to make unique designs, and using the same types of blocks every time gets boring. So, even from a design standpoint, this should have been addressed before the features were released. Not that I'm saying they aren't trying - they definitely are, which is the reason custom world-gen is labeled experimental - it's just that they will need to correct this oversight at some point or another if they want to leave these particular types of configured_feature in the game.

Seems to be another instance of MC-203332. It has the same error and the same replication steps, minus the features and block_state that are affected.

This bug is back, as far as I know. It seems to occur with giant_red_mushroom on cap_state blocks without the properties of red_mushroom_block (up, down, left, right, etc.) and will crash the game on worldgen. Tested in 21w18 using a customized datapack. I will try to create a minimum crash requirements datapack if needed, but it's not really all that complicated to replicate. Just put something like moss_block for a mushroom cap in a feature, distribute it across the overworld (or a custom dimension if you want to only use one biome), generate a world with the new settings, and witness the results.

Additional note, it does actually say "Loot Table", not predicate. I'm not sure why.

The included "Worldgen" folder is located within the "minecraft" namespace, before anyone asks.