mojira.dev

Aikar

Assigned

No issues.

Reported

MC-199487 WorldGen Deadlock Fixed MC-197883 Jigsaw Structures causing DataFixer spam Fixed MC-185263 Non full chunks in cache memory "semi-leak" Fixed MC-183249 Carving Mask BitSets created for lower chunk statuses Fixed MC-145260 Whitelist on state inconsistency Confirmed MC-136886 Finding Nearby Features loads every generated chunk in radius Cannot Reproduce MC-135552 Dead Entities are saved to chunk Fixed MC-135506 Experience saves as a short, used as integer Invalid MC-134668 Over synchronization in ThreadedAnvilChunkStorage impacts performance Invalid MC-134667 Async Chunk Gen dangerously adding entities to world async Fixed MC-134666 Server saves proto chunks Awaiting Response MC-131601 Mob Effects should allow negative amplifier Duplicate MC-110558 Block Entity does not apply enchanting glow if enchanted Duplicate MC-100442 DEV - Navigation Listener very slow code Fixed MC-100382 DEV - Pathfinding Memory Leak Fixed MC-95535 Multiple hopper performance issues Confirmed MC-91214 Client caches skin purely by UUID Duplicate MC-89242 Length of writing text on sign limited by Resource Pack Works As Intended MC-88858 Length of writing text on sign limited by Resource Pack Duplicate MC-75718 CustomNameVisible removed as feature for monsters/animals Invalid

Comments

@Pcobald can you remove that comment? It's spam and does not add anything of value to the conversation.

Unless Mojang asks for more information, no more needs to be supplied for this issue. 

 

So please avoid replying with more stuff until Mojang asks, though last I talked with Mojang on this issue, they seem to understand what the issue is.

This is unlikely to be fixed before 1.17.

Incorrect, it is a server side bug that generating chunks if the right scenarios come into play, will crash the server.

Fix for this issue here: https://github.com/PaperMC/Paper/commit/01b1971a43f56da6418f3f623dc972f46dcff373

 

 

int j = this.c.firstPartial(itemstack);

if (j == -1) {
    j = this.c.getFirstEmptySlotIndex();
}
// Paper start
if (j == -1) {
    this.c.player.drop(itemstack.cloneItemStack(), false);
    break;
}
// Paper end
ItemStack itemstack1 = itemstack.cloneItemStack();

itemstack1.setCount(1);
if (!this.c.c(j, itemstack1)) {
    AutoRecipe.LOGGER.error("Can't find any space for item in the inventory");
}

So what? It will be in it when it is.

 

I am a creator of Paper, It is a vanilla issue.

@Broken-arrow because the logs you pasted in that ticket is in fact a duplicate of this one.

The logs you pasted on Paper's issue tracker looks to be a different issue. the key is "position_predicate" vs "type"

 

I linked the logs in my last reply

 

@Marcono, I can say with confidence my fix can not cause a regression, as it only deals with type/name. I question if Michaels issue is a similar issue but different data set with same problem though.

 

I cant create a ticket for that yet as michael has not provided me enough information to reproduce it yet.

Those errors you saw are 100% a completely different bug. I assume 

 

Mojang, I don't know if a new issue is warranted for this one, but I don't have any more context since can't reproduce my self:

https://pastebin.com/shetqD5e

 

@K.Geraghty Welcome to Paper 🙂 This is what our project is known for, is improving minecrafts performance and security as well as a ton of new features for server owners.

 

We work pretty closely with Mojang to help bring our improvements to the base game, but sadly that process can be a bit slow... 😞

So it's clear for those that didn't interpret it from my last reply providing what the actual problem is here

 

This issue is fixed in Paper 1.16.2 - https://papermc.io/downloads

 

Root issue appears that there are registries that are specifying "name" as their identifier instead of "type"

 

We tried updating the .dispatch() call for Configured World Gen Features to be name instead, and it solved THIS specific issues, but caused others that do actually use "type"...

 

so we have a mixed data set.

Mojang will have to correct the data points to be consistent as type.

 

We're going to bandaid it by checking if type doesnt exists, try name

There is a new issue for the new error: MC-197883

Context of the issue has changed, but end results are similar.

However the bug now also impacts 1.16.1 -> 1.16.2 too.

I've got a report now it even impacts a fresh 1.16.1 generated chunk too.... so impact is a bit higher as it covers everyone doing a point release, and people really dont want to regen worlds for a point release so fast.

Attached a screenshot from a user, appears this is still the same damage as MC-191388 

To reproduce, creating a world in 1.15 and finding a village, and I'm not sure if partial generation applies or not, but if it does, stop moving soon as part of a village is seen, and then open that world in 1.16.2

I will try to attach some files I have reproducing this every time after work too, just need to try to filter it to just needed files first and get coords.

I have one report that it was related to partial generation, but in my own test world I get it at my "Home" location which is a village and i know it was fully generated.

Another suspect is if a village doesn't have a pillar outpost, and my village does not... (likely created in 1.12).

Hope this helps.

 

FYI This is patched (worked around) in Paper 1.15+ (https://papermc.io for those unaware).

The bug lies in the client, but we sent extra light data to the client to avoid this issue.

https://github.com/PaperMC/Paper/blob/b6925c36afa7565cac8f9fe9d3432fe658ca1f77/Spigot-Server-Patches/0496-Workaround-for-Client-Lag-Spikes-MC-162253.patch

@nighter Why is this (which is a same issue as MC-191388  ) marked Won't Fix?

@TPEHEP You don't have to keep asking me this. The developers will update this ticket if they've made progress.

It's up to the developers to note if they fully solved each item I raised. I will update ticket if I detect they made progress as I apply our patches.

 

The above comment is false, please don't disable that config it doesn't relate to this issue

That's called cheating and not something you should do on a survival multi-player server

 

I have updated the ticket with lots of 1.15 relevant information.