mojira.dev

Daniel Widdis

Assigned

No issues.

Reported

MC-253901 "Failed to add PDH Counter" issues (caused by outdated OSHI) Fixed

Comments

It is a summary bug for multiple bugs which have been reported here which you have resolved without fixing:

MC-245565

MC-228430

MC-228393

MC-233152

MC-228885

MC-227785

You will continue to get more bug reports like the above.  Or you can take my word for it that there is a bug in your dependency which you can fix by upgrading.

OSHI maintainer here.

TL;dr:

  • I recommend you update your `oshi-core` dependency version to 5.7.5 to resolve this issue.

Background:

  • There's been a longstanding bug in OSHI (since 3.13.0) where performance counter names were localized, but then used in a method designed for the English counter names.

  • Since there has always been a fallback to (slower) WMI, this didn't cause a failure, just a slower response time.

  • This only impacted users using non-English versions of Windows

  • For a small fraction of those users, some experienced significant delays for yet-unknown reasons that seem to be fixed by rebuilding performance counters

  • This bug has been fixed in 5.7.5 and tested with Minecraft to resolve this report

  • There are no other significant changes in 5.7.5 that would introduce any additional risk to updating the dependency version