mojira.dev

Jack Wilkie

Assigned

No issues.

Reported

View all
MC-8141 Chat Macro Error Incomplete

Comments

ok, sorry if i was a bit hostile, im just a bit annoyed with having to update this issue even when i dont play the game anymore

I will add this, the issue seems to be somewhat improved in recent versions, sometimes only loosing a few letters, and occasionally working properly, however it is clearly not completly fixed

It is still an issue with the latest snapshot

Me not replying in a reasonable time is complete bullshit, this is 1 and a half years old, i have updated it several times due to being requested to, absolutely no action has been taken, it wont be fixed unless someone fixes it. I even fixed it myself some time ago with mcp. I haven't even actively played minecraft in over a year. If you keep treating issues like this then quite a few will never be resolved due to people getting annoyed with your bullshit, just fix the issue already. this isnt exactly a critical bug, but its still annoying, i almost gave up on it, and probably will next time.

yes, it is still valid(updated), please just fix this now/soon, otherwise the version will have to be updated again, which i will forget, resulting in yet another message like this one, and the issue not being resolved

can someone comment, or do anything to this, it has been months since the last activity, and i would like this bug fixed in vanilla

renamed to chat macro error

yes it is, updated with steps to reproduce

i have found a fix using MCP, so it wont look exactly the same to the source code at mojang, but it should be similar enough to showcase what has been changed

in Minecraft.java, where keyboard events are handled, just before the handling of mouse events, change this:

Minecraft.java

}
				var8 = this.gameSettings.chatVisibility != 2;

				while (this.gameSettings.keyBindInventory.isPressed()) {
					this.displayGuiScreen(new GuiInventory(this.thePlayer));
				}

				while (this.gameSettings.keyBindDrop.isPressed()) {
					this.thePlayer.dropOneItem(GuiScreen.isCtrlKeyDown());
				}

				while (this.gameSettings.keyBindChat.isPressed() && var8) {
					this.displayGuiScreen(new GuiChat());
				}

				if (this.currentScreen == null && this.gameSettings.keyBindCommand.isPressed() && var8) {
					this.displayGuiScreen(new GuiChat("/"));
				}

to this

Minecraft.java

var8 = this.gameSettings.chatVisibility != 2;

				while (this.gameSettings.keyBindInventory.isPressed()) {
					this.displayGuiScreen(new GuiInventory(this.thePlayer));
				}

				while (this.gameSettings.keyBindDrop.isPressed()) {
					this.thePlayer.dropOneItem(GuiScreen.isCtrlKeyDown());
				}

				while (this.gameSettings.keyBindChat.isPressed() && var8) {
					GuiChat guiChat = new GuiChat();
					this.displayGuiScreen(guiChat);
					guiChat.handleInput();
				}

				if (this.currentScreen == null && this.gameSettings.keyBindCommand.isPressed() && var8) {
					GuiChat guiChat = new GuiChat("/");
					this.displayGuiScreen(guiChat);
					guiChat.handleInput();
				}
			}

it basicly tells the chatGui to handle input after it is created

also make sure to move that semi-colon from the top of the snippet to the bottom so that all of that code is included in the while(Keyboard.next()){} loop

I have tested this and it fixes the issue perfectly, however i do not understand what all of the code does perfectly, so i suggest not using this fix immediately and instead, see what changed and fix that