Unable to save screenshots and world icons if the path contains non-ASCII characters

This is weird and should not happen. Can you please attach the game's log files (located in [.minecraft|http://hopper.minecraft.net/help/guides/finding-minecraft-data-folder]/logs)?

• If you know you haven't started the game since this issue happened, just attach latest.log

• Otherwise, attach all of the files starting with 2017-11-08 or 2017-11-09.

I found that as soon as I upgraded to this version, there would be problems

Looking at MC-122415, and the screenshots provided by @unknown in this ticket

, apparently this has todo with non-ascii characters in the path name.
I'm not so sure if MC-121830 is really a duplicate and is possibly caused by something different.

Not fixed. Could reproduce it in 18w06a.

It can also be reproduced in 18w08a and 18w08b.
log:

[12:27:28] [Client thread/WARN]: Couldn't save auto screenshot
java.io.IOException: Could not write image to the PNG file "D:\1.13 snapshot\.minecraft\saves\新的世界\icon.png": Corrupt JPEG
at cuh.a(SourceFile:306) ~[18w08b.jar:?]
at cle.n(SourceFile:1049) [18w08b.jar:?]
at cle.a(SourceFile:962) [18w08b.jar:?]
at bya.b(SourceFile:820) [18w08b.jar:?]
at bya.a(SourceFile:381) [18w08b.jar:?]
at net.minecraft.client.main.Main.main(SourceFile:141)

I meet the same problem. I hope it can be resolved quickly. Using 搜狗输入法 to take a screenshot is not convenient.

Can reproduce in 18w08b.

Analysis:

This is an issue in the stb image library, which is used (via the LWJGL binding) to save screenshots. There is an open pull request to fix this; the fix would also need to be applied to the LWJGL version of the library.

I've tried that myself, and while getting LWJGL to build right was hard, that PR (plus some changes to define UNICODE, because I don't have everything set up right) did allow it to build correctly and fix this issue.

However, there is an issue on the MC end, which is the reason for the "Corrupt JPEG" message despite the game loading a PNG. Using 18w10b obf, in cvf (NativeImage?) on line 305:

if (!STBImageWrite.stbi_write_png(lvt_2_1_.UTF8(p_a_1_, true), this.a(), this.b(), 4, MemoryUtil.memByteBuffer(this.d, this.e), 0)) {
            throw new IOException("Could not write image to the PNG file \"" + p_a_1_ + "\": " + STBImage.stbi_failure_reason());
         }

stb_image_write does not do anything with (and in fact does not know about) general stb_image errors; the message returned from STBImage.stbi_failure_reason is unrelated to the reason why the call to stbi_write_png failed. So the "Corrupt JPEG" message doesn't apply, and the call to stbi_failure_reason should probably be removed.

Perhaps it would also make sense to use stbi_write_png_to_func, and manually handle writing to disk, as that should bypass this unicode issue.

I'm not sure where the "Corrupt JPEG" part comes from, but as a quick note I did build lwjgl_stb.dll with the "non-user-friendly" message mode, and I got "no SOI" instead which indicates an error in stbi__decode_jpeg_header. This is probably from some earlier code, but I don't know which.

18w21a affected

18w22c affected