mojira.dev
MC-129826

["shade": false] is missing from potted cross models, resulting in most potted plants appearing darker than they should

The bug

When blocks were being converted over to using model files in 1.8, several of these conversions were incomplete and flawed, resulting in a multitude of issues. Many of these were resolved before the release of 1.8, however this specific issue was not.

In 14w25a, models involving flat 2D planes had those planes be rendered darker depending on their directions. This affected blocks such as grass, flowers and mushrooms, and was ultimately fixed (MC-57159). However, the same version also caused plants in flower pots to appear darker for the same reason, and this was not fixed.

As a result, plants which are placed in flower pots appear noticeably darker than those same plants when placed in the world (outside of a flower pot), which has been the case since 14w25a.

A comparison of the appearances of potted objects can be found below:

1.4.2 - 1.7.10 (expected rendering)

1.8 - present (incorrect rendering)

[media]

[media]

How to fix

This is ultimately incredibly easy to fix - the two texture plane elements in "flower_pot_cross.json" and its tinted version "tinted_flower_pot_cross.json" simply need a

"shade": false

line added to them, which should resolve this unwanted darkening.

A comparison of potted objects with and without the fix can be found below:

22w11a (current rendering)

22w11a (fixed rendering)

[media]

[media]

Further notes

22w11a implemented potted mangrove propagules, which are completely unaffected by this issue affected slightly differently (see MC-262696) as they have a unique, dedicated model. Despite this, shading was not disabled for existing potted crosses in this version.

[media]

Linked issues

Attachments

Comments

migrated

Confirmed in 18w22a.

migrated

Confirmed in 18w22c.

migrated

Confirmed in 1.13-pre5.

migrated

Was able to re-create this in Minecraft 19w14b.

TheBoy358

Confirmed in 1.14.4 and 19w45a.

SoloAlguien

Confirmed in 1.16.4 and 20w51a.

To fix this, the shading has to be removed from the plants (like when they are in the soil without a pot).
Files with the fix: 

[media][media]
SoloAlguien

Also I attached screenshots of the wrong and fixed versions:

[media][media]
Avoma

Can confirm in 20w51a.

SoloAlguien

Confirmed in 21w03a.

Avoma

Can confirm in 21w05b.

Avoma

Can confirm in 21w06a.

SoloAlguien

Can confirm in 21w10a.

SoloAlguien

Can confirm in 21w11a.

SoloAlguien

Attached a resource pack with the fix.

[media]
SoloAlguien

Can confirm in 21w13a.

SoloAlguien

Can confirm in 21w14a.

SoloAlguien

Can confirm in 21w16a.

migrated

Duplicate of MC-68302

SoloAlguien

Maybe this work as intended, since MC-68302 was solved in this way.
I personally think the pots don't look good the way they are now and I don't think MC-68302 has given the best examples and comparisons of this specific case.
I would like, if possible, that the decision be made with the images provided here.

 

SoloAlguien

Can confirm in 1.17 Pre-release 1.

SoloAlguien

Can confirm in 1.17 Pre-release 2.

SoloAlguien

Can confirm in 1.17 Pre-release 3.

SoloAlguien

Can confirm in 1.17 and 1.17.1 Pre-release 1.

SoloAlguien

Can confirm in 1.17.1.

SoloAlguien

Can confirm in 21w39a.

muzikbike

Affects 21w40a.
Requesting ownership as the creator has no activity for 11 months, as well as the fact that my ticket about this was resolved as a duplicate despite offering substantially more information, which would usually result in a ticket like this being forward-resolved.

SoloAlguien

Can confirm in 21w42a.

Avoma

@unknown, this is unrelated to this issue. Please see MCL-16570.

SoloAlguien

Can confirm in 1.18 Pre-release 1.

SoloAlguien

Can confirm in 1.18 and 1.18.1 Pre-release 1.

SoloAlguien

Can confirm in 1.18.1.

SoloAlguien

Can confirm in 1.18.2.

muzikbike

An interesting thing to note is that mangrove propagules have been given a dedicated model, and that this issue is not present on this model due to shading have been explicitly disabled for it. Curiously, despite this, the existing cross models have been left in their shaded state:

[media]

Avoma

Can confirm in 1.19.

Avoma

Can confirm in 1.19.2.

migrated

i can confirm in 1.19.3 and 23w04a

muzikbike

coschevi

Confirmed

Gameplay

Low

Rendering

1.8-bad-model-conversion-remnants, 1.8-model-conversion-remnants, 14w25a, unwanted-model-shading, vanilla-parity

Minecraft 1.12.2, Minecraft 18w20c, Minecraft 18w22a, Minecraft 18w22c, Minecraft 1.13-pre5, ..., 1.19.3, 23w04a, 23w18a, 1.20.1, 1.20.4

24w33a

Retrieved