[MC-131337] Trident on fire does not set mobs on fire

The bug

If you throw a trident through lava, the trident projectile will be set on fire, but mobs it hits won't be set on fire.

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

is duplicated by 1

MC-133393 Throwing a trident through lava make it on fire but not make mobs on fire Resolved

relates to 1

MC-257166 Tridents returning due to the loyalty enchant cannot light tnt Resolved

Attachments

MC-131337.mp4

Comments 14

gaspoweredpick 2018-06-15T02:18:50Z

Just so that you know, You're supposed to put your description of the bug under "Description", not Environment".

CreeperMagnet_ 2018-06-27T01:05:27Z

Can confirm for 1.13-pre4.

CreeperMagnet_ 2018-07-04T23:44:35Z

Affects 1.13-pre6.

Oval 2018-09-23T01:26:47Z

Confirmed for 1.13.1.

Avoma 2021-01-13T14:37:56Z

Can confirm in 20w51a.

4 more comments

ampolive 2021-07-16T23:17:57Z

Can confirm in 1.17.1.

Avoma 2022-05-15T09:13:53Z

Can confirm in 1.18.2 and 22w19a.

Avoma 2022-06-22T14:37:31Z

Can confirm in 1.19.

Avoma 2022-09-11T15:05:48Z

Can confirm in 1.19.2.

ampolive 2023-11-09T22:07:25Z

Code analysis (Mojang mappings, 23w45a): This is because ThrownTrident#onHitEntity does not check if it is on fire and set the hit entity on fire like in AbstractArrow#onHitEntity. This could be a potential fix:

...
        if ($$1.hurt($$5, $$2)) {
            if ($$1.getType() == EntityType.ENDERMAN) {
                return;
            }
            // Added
            if (this.isOnFire()) {
               $$1.setSecondsOnFire(5);
            }
            ...
        } else if ($$1.getType().is(EntityTypeTags.DEFLECTS_TRIDENTS)) {
            this.deflect();
            return;
        }
        ...