[MC-163242] Blocks on armor stands render shadows based on camera vector

Changes in 19w42a

Since 19w42a, dropped items are no longer affected. Armor stand effects are essentially unchanged since the last snapshot. Also this bug still applies to items held by endermen.

The bug

Item models render their shadows differently, depending on at which angle the player is looking at them. When looking at a block on the head of an armor_stand, the shading changes drastically depending on how the camera is viewing it.

Steps to reproduce

Summon an armor stand with a stone head item and circle the cursor around it while staying still. Note the brightness changes.

/summon minecraft:armor_stand ~ ~ ~ {ArmorItems:[{},{},{},{id:"minecraft:stone",Count:1}],Marker:1,Invisible:1,NoGravity:1}

Visual Evidence

Block Model

[media]

Note that this is a stone block on the head of an armor_stand, so it is being rendered as an entity not a block in the world.

Linked issues

is duplicated by 2

MC-163260 Items and entities displaying items have incorrect shading Resolved

MC-164761 Blocks are rendered darker when a mob wearing a block on head, depending on the angle they are looked from Resolved

relates to 1

MC-161840 Entities are shaded far darker than usual Resolved

Attachments

Comments 4

violine1101 2019-10-10T08:54:46Z

This also applies to the block held in the player's hand. Look up and down while holding a stone block, you'll see that it's shaded incorrectly. See also MC-163102 for a very similar issue related to items that are biome-dependent.

Edit: There's also MC-163242, which I'll leave open to have a specific ticket for items being held in the hand around.

TheBoy358 2019-10-16T19:20:45Z

Seem to be not fixed in 19w42a.

wobst.michael 2019-10-16T19:24:19Z

Confirmed not completely fixed in 19w42a.

Jatzylap 2019-10-28T16:47:46Z

Can confirm for items using a custom model, and relates to held item light rendering

EDIT: (see MC-163105)