Fry

Is this still an issue in 1.18 Pre-release 2?

Please provide seed/coordinates for 1.18 Pre-release 1, if the issue is still happening

@unknown was the world created fresh in 1.18 Pre-release 1, or was it created earlier?

Is this still an issue in 1.18 pre-release 1?

Is this still an issue in 1.18 pre-release 1? fluid propagation was improved

Is this still an issue in 21w44a? Please try loading directly from 1.17.1 to 21w44a; for worlds loaded in 21w43a erasing the caches might solve the issue (Select world in the menu, press Edit, press Optimize World, check Erased cached data checkbox, proceed)

Is this still an issue in the latest snapshot?

Hi! Could you please attach the full server log with the crash on the latest snapshot? It should contain more debugging information that should help us track down this issue

The glass block does not render it's faces when seen from the inside; is that the only issue you see, or is there something else?

Is this still an issue in the latest pre-release?

Please post the full game log if you experience this issue, in addition to the crash report.

Pack has version 4, which is the format used in 1.14; 1.15 will use version 5, and version 4 is partially updated to that when possible, but this pack has banner patterns in 1.15 format, which makes them break on load; you need to either roll them back to 1.14 format, or update the pack fully to 1.15 format

behaves a little weirdly

Can you be more specific? 🙂

No worries, better safe then sorry 😉

If this is still happening to you, and if you have a backup of the world right before you can trigger the issue, that might help; I managed to get one and consistently reproduce it, and fixed what was causing it, but there might be more to it; if you can reproduce it by

1. Restoring the backup

2. Choosing edit -> optimize -> erase cached data (before loading it)

3. See the issue immediately after loading the world

Then it would be very helpful if you can share your world backup, along with what render distance you're using.

Thanks!

Is this the same as https://bugs.mojang.com/browse/MC-151079 ?

1.14 or 1.14.1-pre1? One of the fixed issues was for the server shutdown code.

Does this still happen in 1.14.1-pre1 with either a new world, or a world with an erased cache? Please keep in mind that it's possible to trigger it, close the game, but not see it until you load the world the next time.

This bug is taking so long because we have not found any way at all to trigger it on demand; I never manager to trigger it once on my machine, and there seems to be no action in particular that makes it more or less likely to happen; a few potential causes of this error were fixed in 1.14.1-pre1, but without being able to check there's no way to know for sure.

Triggered by some change in lwjgl 3.2.1 (works fine on 3.2.0). We rolled back to 3.1.6, but that caused MC-148461; proper fix coming later

Thanks for the analysis, it's very much appreciated.

First part of the issue was indeed a simple omission - already lit chunks were not marked as such after reloading.

Initializing the light using the implicit light level was the initial approach I tool, but it was not compatible with the worldgen/recomputation of data, since it is only correct if the chunk section is only filled with air/non light blocking blocks, so initially it resulted in full chunks filled with skylight; it should be done if the light for the chunk is in a computed state already, and when the new section needs to be stored for that chunk; I tried that approach, but it caused large dark spots of light to appear during worldgen, which I think is caused either by not quite right order of operations in worldgen lighting, or by MC-148723, or by some other issue; I'll re-enable it after fixing that, and we'll see what happens 🙂