mojira.dev
MC-163893

Held item lighting in first person doesn't change accordingly in relation with light sources

The bug

Back in 1.14 and before, in first person the item's on-model shadows changed accordingly to light (blocks that glow, the moon, the sun), but now the shadows don't change, not even with a really near light source.

The only item that I found that works as it should is the trident, the shadows change accordingly to the enviroment.

Update: The bug has been partially fixed in 19w45, but the lighting still behaves a little weirdly.

To reproduce

  1. Be in first person mode

  2. Pick any item and then hold it

  3. Pick any source of light (the sun, the moon, a torch, etc)

  4. Move your point of view in relation to the source of light.

Do this in 1.14.4 (or any previous version), and then in 19w42a

Comments 12

Shadows of held items are still dynamic in third person; only first person is affected.

Yes, but it doesn't really specify that it's working in 3rd person.
I for example would not have been sure that this feature also exists in 3rd person in previous versions.

It working in 3rd confirms, that the responsible code is still present, even after all the rendering changes.

Title: Held item lighting in first person doesn't change accordingly in relation with light sources

 

In the bug description:

 

How to reproduce:

 

Be in first person mode

 

 

In those two instances it says that the bug is present only in first person

 

 

2 more comments

I don't know how to say it, I just can say that it doesn't feel right compared to how it behaved in 1.14.4 and before, maybe someone could attatch 2 videos showing the difference, because if I recorded a video I would have to compress it a lot to be able to attatch it to this report, and because of the compressing the issue would be difficult to notice.

The only way I can put it is that now the lighting is applied close to how it should be, but it is still off.

If someone could provide a short video showcasing the issue, that would be very helpful.

@unknown If you have a video that is too big in file size to be uploaded to the tracker directly, you can upload it elsewhere (e.g. as an unlisted video on youtube) and link it here.

Please add further information about how the problem looks like in 19w46b or later.

I went to 1.14.4 and then to 19w46b and I don't see any lighting difference so it might be fixed.

Nightwind8887

(Unassigned)

Confirmed

Important

Rendering

first-person, item, light-source, lighting, lighting-engine

19w42a, 19w44a, 19w45a, 19w46a

19w46b

Retrieved