[MC-214147] Skeletons wearing leather armor still convert to strays in powder snow

I wouldn't expect this to happen, especially because leather armor prevents freezing which should prevent skeletons being converted.

The changelog states: "Skeletons now convert to strays when frozen", and as they are not frozen because of the leather armor, they should not convert into strays

To reproduce:
1. Run

/summon skeleton ~ ~ ~ {ArmorItems:[{},{},{Count:1,id:leather_chestplate},{}]}

2. Observe results

Code analysis

Code analysis by @unknown can be found in this comment.

Attachments

MC-214147.mp4

Comments 17

Seaworths 2021-02-05T15:59:18Z

Okay what. I would have never ever come up with the idea of checking that xD good job

Avoma 2021-02-11T16:53:15Z

Can confirm in 21w06a.

Avoma 2021-02-18T13:01:32Z

Can confirm in 21w07a.

Avoma 2021-03-20T11:43:53Z

Can confirm in 21w11a. Video attached.

Avoma 2021-04-06T10:32:39Z

Can confirm in 21w13a.

7 more comments

Avoma 2022-03-22T18:21:02Z

Can confirm in 1.18.2 and 22w11a.

ampolive 2022-03-22T18:32:36Z

Code analysis (using Mojang mappings, 22w11a): there are no checks carried to see if the skeleton is wearing a piece of leather armor in order to start the conversion process, as can be seen in Skeleton#tick():

if (!this.level.isClientSide && this.isAlive() && !this.isNoAi()) {
            if (this.isFreezeConverting()) {
                ...
            } else if (this.isInPowderSnow) {
                ++this.inPowderSnowTime;
                if (this.inPowderSnowTime >= 140) {
                    this.startFreezeConversion(300);
                }
            } 
            ...
        }

Changing this line:

if (this.inPowderSnowTime >= 140)

to this:

if (this.inPowderSnowTime >= 140 && this.canFreeze())

should fix the issue.

Avoma 2022-06-25T10:33:52Z

Can confirm in 1.19.

Avoma 2022-09-01T14:37:08Z

Can confirm in 1.19.2.

user-f2760 2023-01-23T18:52:38Z

The priority assigned by Mojang says otherwise.