When using the new Minecraft 1.19 seed field for the sound packet it is expected to produce the same sound "variant" for each player. However, for players who are using resource packs, this is not the case. It should be noted, however, that these resource packs do not modify any sounds in any way.
The reason for this is that each sound "variant" is registered again in a WeightedSoundSet for each resource pack in SoundManager.Preparations#handleRegistration.
block.amethyst_cluster.break WeighedSoundEvents stored sounds with 0 resource packs:
[Sound[minecraft:block/amethyst_cluster/break1], Sound[minecraft:block/amethyst_cluster/break2], Sound[minecraft:block/amethyst_cluster/break3], Sound[minecraft:block/amethyst_cluster/break4]]block.amethyst_cluster.break WeighedSoundEvents stored sounds with 3 resource packs:
[Sound[minecraft:block/amethyst_cluster/break1], Sound[minecraft:block/amethyst_cluster/break2], Sound[minecraft:block/amethyst_cluster/break3], Sound[minecraft:block/amethyst_cluster/break4], Sound[minecraft:block/amethyst_cluster/break1], Sound[minecraft:block/amethyst_cluster/break2], Sound[minecraft:block/amethyst_cluster/break3], Sound[minecraft:block/amethyst_cluster/break4], Sound[minecraft:block/amethyst_cluster/break1], Sound[minecraft:block/amethyst_cluster/break2], Sound[minecraft:block/amethyst_cluster/break3], Sound[minecraft:block/amethyst_cluster/break4], Sound[minecraft:block/amethyst_cluster/break1], Sound[minecraft:block/amethyst_cluster/break2], Sound[minecraft:block/amethyst_cluster/break3], Sound[minecraft:block/amethyst_cluster/break4]]
It is expected that sounds are not re-registered like this, which as a result will cause sound packets sent with seeds to produce unpredictable sounds for those with resource packs.
This issue can be reproduced by applying any resource pack and sending a sound with a certain seed, and it can be noticed that it may produce a different sound. In this case, a sound with the seed of -2471965959928200000L was used with the block.amethyst_cluster.break sound.
Comments 4
MC-252273 absolutely not, it's very poorly worded and just refers to the second splash in the same sound file.
Can confirm in-game through a load error in a resource pack:
14:57:49.835
fmb
Worker-Main-4
File medabots_server:sounds/no_sound.ogg does not exist, cannot add it to event minecraft:music.overworld.jungle_and_forest
14:57:49.863
fmb
Worker-Main-4
File medabots_server:sounds/no_sound.ogg does not exist, cannot add it to event minecraft:music.overworld.jungle_and_forest
14:57:49.893
fmb
Worker-Main-4
File medabots_server:sounds/no_sound.ogg does not exist, cannot add it to event minecraft:music.overworld.jungle_and_forestThe top of the 3 resource packs had this:
"music.overworld.jungle_and_forest": {
"replace": true,
"sounds": [
{
"name": "medabots_server:no_sound",
"stream": false
}
]
}Note, the "replace", which actually should make the lower packs ignore this.
This would probably explain MC-249973.