[MC-259813] /damage can print untranslated "player" and "item" variants of some death messages

The bug

Death message translation keys can be generated with .item ("died to enemy using...") and .player ("died while fighting...") suffixes. In vanilla survival, not all of these are possible, but with /damage, all combinations are possible. Vanilla doesn't have translations for some of these keys.

How to reproduce

item

/item replace entity @s weapon with apple{display:{Name:'"Apple of death"'}}
/damage @s 20 cactus by @s

❌ Prints "death.attack.cactus.item"

player

/summon cow
/damage @s 1 cactus by @e[type=cow,limit=1]
/damage @s 20 trident

❌ Prints "death.attack.trident.player"

Full list of missing translations

Damage Type	Death Message
`minecraft:player_explosion`	`death.attack.explosion.player.player`
`minecraft:out_of_world`	`death.attack.outOfWorld.item`
`minecraft:arrow`	`death.attack.arrow.player`
`minecraft:cactus`	`death.attack.cactus.item`
`minecraft:cramming`	`death.attack.cramming.item`
`minecraft:dragon_breath`	`death.attack.dragonBreath.item`
`minecraft:drown`	`death.attack.drown.item`
`minecraft:dry_out`	`death.attack.dryout.item`
`minecraft:explosion`	`death.attack.explosion.item`
`minecraft:fall`	`death.attack.fall.item`
`minecraft:falling_anvil`	`death.attack.anvil.item`
`minecraft:falling_block`	`death.attack.fallingBlock.item`
`minecraft:falling_stalactite`	`death.attack.fallingStalactite.item`
`minecraft:fireball`	`death.attack.fireball.player`
`minecraft:fly_into_wall`	`death.attack.flyIntoWall.item`
`minecraft:freeze`	`death.attack.freeze.item`
`minecraft:generic`	`death.attack.generic.item`
`minecraft:generic_kill`	`death.attack.genericKill.item`
`minecraft:hot_floor`	`death.attack.hotFloor.item`
`minecraft:indirect_magic`	`death.attack.indirectMagic.player`
`minecraft:in_fire`	`death.attack.inFire.item`
`minecraft:in_wall`	`death.attack.inWall.item`
`minecraft:lava`	`death.attack.lava.item`
`minecraft:lightning_bolt`	`death.attack.lightningBolt.item`
`minecraft:magic`	`death.attack.magic.item`
`minecraft:mob_attack` `minecraft:mob_attack_no_aggro` `minecraft:mob_projectile`	`death.attack.mob.player`
`minecraft:outside_border`	`death.attack.outsideBorder.item`
`minecraft:player_attack`	`death.attack.player.player`
`minecraft:stalagmite`	`death.attack.stalagmite.item`
`minecraft:starve`	`death.attack.starve.item`
`minecraft:sweet_berry_bush`	`death.attack.sweetBerryBush.item`
`minecraft:thorns`	`death.attack.thorns.player`
`minecraft:thrown`	`death.attack.thrown.player`
`minecraft:trident`	`death.attack.trident.player`
`minecraft:wither`	`death.attack.wither.item`
`minecraft:wither_skull`	`death.attack.witherSkull.player`

Linked issues

is duplicated by 1

MC-259840 uses of /damage with certain damage type and damage source cause death message with broken translation Resolved

relates to 2

MC-259790 /damage can provide fewer variables to death message than expected, printing unformatted message Open

MC-262531 "death.attack.genericKill.player" displays raw translation string (is untranslated) Resolved

Attachments

2023-02-09 18-19-55.mp4

2023-02-09 18-23-40.mp4

Comments 3

EpicGamerX125 2023-02-08T20:31:30Z

When looking in the en_us.json file, none of the above listed translation strings are actually defined in the file, which is probably the reason why they display like this.

For the explosion one there's a definition for death.attack.explosion.player.item but not death.attack.explosion.item.

Shuddery 2023-05-10T21:00:46Z

Added more death messages added in 1.20pre1

[Mod] ManosSef 2023-05-11T17:22:58Z

"death.attack.genericKill.player" doesn't count, it can appear without /damage