The Bug:
Sniffer digging particles are produced slightly too high up.
Steps to Reproduce:
Summon a sniffer and wait for it to begin sitting and digging.
Look at the particles that the sniffer produces upon digging.
Take note as to whether or not sniffer digging particles are produced slightly too high up.
Observed Behavior:
Sniffer digging particles are produced slightly too high up.
Expected Behavior:
Sniffer digging particles would be produced slightly lower down.
Attachments
Comments 3
Code analysis (Mojang mappings, 1.19.4-rc2): Sniffer#emitDiggingParticles(AnimationState) creates the particles based on the block position of the sniffer's head, and then uses Vec3#atCenterOf(Vec3i) to add (0.5, 0.5, 0.5) to the block position, causing the particles to be created on the center of the block. It instead should use Vec3#atBottomCenterOf(Vec3i), which adds (0.5, 0, 0.5), which would cause the particles to be created on the ground.
I can confirm. This can be very noticeable when looking below the sniffer in an upwards direction.