HRTF stuck on even when directional audio is set to off in update 1.20.2

Can reproduce

Interestingly enough, I have experienced this issue with both HRTF being stuck on and HRTF being stuck off, depending on where I run the game (in a third party launcher HRTF is stuck on, but in FabricMC's Loom dev environment HRTF is stuck off). After some investigation, I think I found the cause of the issue.

Code Analysis

In com.mojang.blaze3d.audio.Library, the init method calls the setHrtf method to set directional audio on or off.

// Inside: public void init(String audioDevice, boolean hrtfEnabled)

this.setHrtf(deviceCapabilities.ALC_SOFT_HRTF && hrtfEnabled);

Inside the setHrtf method, the alcResetDeviceSOFT method is called on the current audio device with two attributes. The ALC_HRTF_SOFT attribute sets HRTF on or off, and the ALC_HRTF_ID_SOFT attribute sets the index of the desired HRTF file, which is currently hardcoded to 0.

// Inside: privatevoid setHrtf(boolean hrtfEnabled)

var attributes = memory.callocInt(10)
        .put(SOFTHRTF.ALC_HRTF_SOFT).put(hrtfEnabled ? ALC10.ALC_TRUE : ALC10.ALC_FALSE)
        .put(SOFTHRTF.ALC_HRTF_ID_SOFT).put(0)
        .put(0).flip();
if (!SOFTHRTF.alcResetDeviceSOFT(this.currentDevice, attributes)) {
    // ...
}

According to this text document, the alcResetDeviceSOFT method should be used for resetting an audio device's attributes so that they may be changed during runtime.

While the code above functions correctly in resetting an audio device's attributes with new values, its effect is imminently overridden by the creation of a new audio device context, which replaces the current audio device's attributes.

// Inside: public void init(String audioDevice, boolean hrtfEnabled)

// Attributes enabling/disabling HRTF are set here...
this.setHrtf(deviceCapabilities.ALC_SOFT_HRTF && hrtfEnabled);
try (var memory = MemoryStack.stackPush()) {
    var attributes = memoryStack.callocInt(3)
            .put(SOFTOutputLimiter.ALC_OUTPUT_LIMITER_SOFT).put(ALC10.ALC_TRUE)
            .put(0).flip();
    // ...but are immediately overriden here.
    this.context = ALC10.alcCreateContext(this.currentDevice, attributes);
}

Before Minecraft snapshot 23w31a, this was not an issue as no attributes were given in the creation of a new context. However, in 23w31a, the ALC_OUTPUT_LIMITER_SOFT attribute was added to the context creation, nullifying the effect of the setHrtf method from before.

Probably the most straightforward way to fix this is to move the calling of setHrtf after the creation of the audio device's context.

However, this creates the opposite problem where the ALC_OUTPUT_LIMITER_SOFT attribute is nullified by calling setHrtf. So, it may be simpler to just set all attributes at once.

// Inside: public void init(String audioDevice, boolean hrtfEnabled)

// Deleted:
// this.setHrtf(deviceCapabilities.ALC_SOFT_HRTF && hrtfEnabled);

try (var memory = MemoryStack.stackPush()) {
    // int allocation increased from 3 to 7, as there could be 4 additional int values
    var attributes = memory.callocInt(7);

    attributes.put(SOFTOutputLimiter.ALC_OUTPUT_LIMITER_SOFT).put(ALC10.ALC_TRUE);

    // Set attributes enabling or disabling HRTF during context creation
    if (ALC10.alcGetInteger(this.currentDevice, SOFTHRTF.ALC_NUM_HRTF_SPECIFIERS_SOFT) > 0) {
        attributes.put(SOFTHRTF.ALC_HRTF_SOFT).put(
                deviceCapabilities.ALC_SOFT_HRTF && hrtfEnabled ?
                ALC10.ALC_TRUE : ALC10.ALC_FALSE);
        attributes.put(SOFTHRTF.ALC_HRTF_ID_SOFT).put(0);
    }

    this.context = ALC10.alcCreateContext(this.currentDevice, attributes.put(0));
}

I have implemented these changes in a FabricMC mod for testing purposes, and it seems to have fixed the issue for me. The source code for the mod can be accessed here: https://github.com/bytzo/mc-265514. Obligatory warning to proceed with caution: while I can trust myself, you can't trust me, so please audit the code yourself before compiling or running.