[MC-266724] scoreboard players reset <targets> <objective> no longer works

The scoreboard players reset <targets> <objective> command no longer works. Resetting them for all scoreboards does still seem to work.

Steps to reproduce:

Add the scoreboard using /scoreboard objectives add TestScoreboard dummy
Give example a score using /scoreboard players set example TestScoreboard 123
Reset the score using the following command /scoreboard players reset example TestScoreboard
Try to get example's score using /scoreboard players get example TestScoreboard
Notice how the score is still present
(Alternatively you can use /scoreboard objectives setdisplay sidebar TestScoreboard and see the score being displayed in the sidebar)

Linked issues

is duplicated by 4

MC-266726 Updating a scoreboard player's display name/numberformat style gets them to keep a score of 0, forever Resolved

MC-266727 Scoreboard objectives cannot be reset Resolved

MC-266733 Scoreboard reset does not work in snapshot 23w46a Resolved

MC-266757 scoreboard players reset does not work now Resolved

Attachments

scoreboard_players_reset.mp4

Comments 1

DrexHD 2023-11-17T00:20:17Z

Simple code analysis (official mappings):
PlayerScores

public boolean remove(Objective objective) {
return this.scores.get(objective) != null;
{{}}}
This method is used by the Scoreboard to remove a specific objective from a "Player", but the current implementation doesn't remove it.
To actually remove the objective entry from the scores Map, it needs to be replaced with something like this:

public boolean remove(Objective objective) {
return this.scores.remove(objective) != null;
{{}}}
I have written a simple fabric mod to fix this bug!