mojira.dev

DrexHD

Assigned

No issues.

Reported

MC-277452 Player idle timeout does not kick players Fixed MC-274187 The sweeping attack from a sword enchanted with Fire Aspect can ignite other players with PVP disabled Fixed MC-274185 Fire aspect sweeping attack sets sweeped targets on fire Works As Intended MC-270867 Severe lag when upgrading 1.20.4 worlds Fixed MC-269642 Eating an oversized Soup / Stew resets the stack size to 1 Fixed MC-140006 Missing water on underwater structure Duplicate MC-138871 Entities duplicate and disappear Cannot Reproduce MC-138833 Interaction with hoppers has crashed our server and cleared some of our players chests Awaiting Response MC-123981 NBT CustomName seems to only accept integers Duplicate

Comments

Code analysis:

In 24w14a Filterables Codec was changed from using the field name text to using raw. To adjust for this ItemStackComponentizationFix was adjusted as well. However ItemStackComponentizationFix is only run when upgrading format from 24w08a to 24w09a, so this fix won't be applied to any worlds created between 24w09a and 24w13a. To fix this a separate datafixer needs to be added instead. The fix in ItemStackComponentizationFix should probably also be reverted as it may have the same effect as this bug on worlds from pre 24w09a upgraded to 24w09a through 24w13a (untested)

I have created a simple fabric mod to fix this issue: MC-270325

Simple code analysis (official mappings):
PlayerScores

public boolean remove(Objective objective) {
    return this.scores.get(objective) != null;
{{}}}
This method is used by the Scoreboard to remove a specific objective from a "Player", but the current implementation doesn't remove it.
To actually remove the objective entry from the scores Map, it needs to be replaced with something like this:

public boolean remove(Objective objective) {
    return this.scores.remove(objective) != null;
{{}}}
I have written a simple fabric mod to fix this bug!

-- System Details ---- System Details --Details: Minecraft Version: 18w44a Operating System: Linux (amd64) version 4.17.4-1.el7.elrepo.x86_64 Java Version: 1.8.0_171, Oracle Corporation Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Oracle Corporation Memory: 902773656 bytes (860 MB) / 2822766592 bytes (2692 MB) up to 2863661056 bytes (2731 MB) JVM Flags: 2 total; -Xmx3072M -Xms128M Player Count: 9 / 2018; [uc['DrexHD'/5102, l='world', x=25.04, y=16.00, z=27.42], uc['Hexo_mc'/7615, l='world', x=-80817.04, y=58.50, z=-21692.29], uc['_N0VA__'/10680, l='world', x=63.50, y=66.00, z=37.50], uc['wolfie_fan'/14912, l='world', x=-21259.84, y=81.00, z=-41994.52], uc['SnakeHunt3r'/15526, l='world', x=-80818.68, y=60.00, z=-21691.59], uc['davidtaco999'/15528, l='world', x=41046.39, y=58.00, z=-82909.69], uc['CaptainFireBall'/15886, l='world', x=83377.97, y=72.00, z=-26505.08], uc['BlueMangoBango'/17282, l='world', x=-80132.82, y=38.00, z=3199.92], uc['ReAnimatedEnder9'/16652, l='world', x=83377.50, y=72.10, z=-26503.50]] Data Packs: vanilla, file/kilocraft (incompatible) Is Modded: Unknown (can't tell) Type: Dedicated Server (map_server.txt)

We have our world since 18w43a, but I do not think, that that is the error

World: http://www.mediafire.com/file/upgv34y8kjfqs3b/broken-chunk.zip/file

At coordinates 8440780 | 78 | 6624001

In single and multiplayer

Version: 1.13 pre8