[MC-268854] Firework explosions in items without a `Type` field are not correctly upgraded

Step to step guide to reproduce:

In an older version use a command block to give yourself a firework with an explosion containing no `Type` field (should default to `small_ball`).
Update to the latest snapshot. The explosions will have been dropped from the firework.

Attachments

2024-04-11_15-57-22_upgrade test.zip

Comments 4

[MOD] Greymagic27 2024-03-08T21:12:38Z

Please may you add a step to step guide detailing how to reproduce this issue?

AgentM 2024-03-08T21:27:59Z

Added a step by step reproduction

[MOD] Greymagic27 2024-04-02T14:16:28Z

Can you provide the needed commands to give the firework with X amount of explosions?

tryashtar 2024-04-11T21:59:36Z

I can confirm, though I'm updating the description a bit to match my latest observations. In particular, the maximum number of firework explosions is now 256, not 16, but exceeding the limit still deletes all of them.
I wasn't able to reproduce any issues with enchantments; ones that were out of range were set to 255 after upgrading.
I've attached the 1.20.4 world here