Breaking two-block plants shows wrong breaking particles

Maybe caused by MC-54131

Confirmed for 14w19a.

Fixed in 14w30c

Unable to reproduce. Does this happen when breaking other double-tall plants and when there isn't a double-tall grass block behind?

Reopened (MC-92296)

Confirmed for 15w46a.

Confirmed for 15w47c
Also affect the Spectator Mode.

Please link to this comment in the description of the report.

The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.

The following reason and fix are based on missing (always 8) meta data values for the upper part of a double_plant. There might be other ways of solving this but this is the most logic to me.
This changes requires changes in the methods called by the world generation and when a player places a double plant as well because they ignore currently the flower type for the upper part.

Missing meta data for upper parts

Affected class: net.minecraft.block.BlockDoublePlant
Affected methods:

public IBlockState getStateFromMeta(int meta)

/**
 * Convert the given metadata into a BlockState for this Block
 */
public IBlockState getStateFromMeta(int meta)
{
    // Replaced this
    //return (meta & 8) > 0 ? this.getDefaultState().withProperty(HALF_PROP, BlockDoublePlant.EnumBlockHalf.UPPER) : this.getDefaultState().withProperty(HALF_PROP, BlockDoublePlant.EnumBlockHalf.LOWER).withProperty(VARIANT_PROP, BlockDoublePlant.EnumPlantType.func_176938_a(meta & 7));
    EnumBlockHalf position;
    if (meta < 8) {
        position = EnumBlockHalf.LOWER;
    }
    else {
        position = EnumBlockHalf.UPPER;
    }
    return this.getDefaultState().withProperty(HALF_PROP, position).withProperty(VARIANT_PROP, BlockDoublePlant.EnumPlantType.func_176938_a(meta & 7));
}

public int getMetaFromState(IBlockState state)

/**
 * Convert the BlockState into the correct metadata value
 */
public int getMetaFromState(IBlockState state)
{
    // Replaced this
    //return state.getValue(HALF_PROP) == BlockDoublePlant.EnumBlockHalf.UPPER ? 8 : ((BlockDoublePlant.EnumPlantType)state.getValue(VARIANT_PROP)).func_176936_a();
    int meta = ((BlockDoublePlant.EnumPlantType)state.getValue(VARIANT_PROP)).func_176936_a();
    if (state.getValue(HALF_PROP) == BlockDoublePlant.EnumBlockHalf.UPPER) meta += 8;
    return meta;
}

Missing flower type for upper parts

This covers the bug that currently for the upper parts no flower type is set because they would lose this information because of the missing meta values anyway

Affected class: net.minecraft.block.BlockDoublePlant
Affected methods:

public void func_176491_a(World worldIn, BlockPos p_176491_2_, BlockDoublePlant.EnumPlantType p_176491_3_, int p_176491_4_)

public void func_176491_a(World worldIn, BlockPos p_176491_2_, BlockDoublePlant.EnumPlantType p_176491_3_, int p_176491_4_)
{
    worldIn.setBlockState(p_176491_2_, this.getDefaultState().withProperty(HALF_PROP, BlockDoublePlant.EnumBlockHalf.LOWER).withProperty(VARIANT_PROP, p_176491_3_), p_176491_4_);
    // Replaced this
    //worldIn.setBlockState(p_176491_2_.offsetUp(), this.getDefaultState().withProperty(HALF_PROP, BlockDoublePlant.EnumBlockHalf.UPPER), p_176491_4_);
    worldIn.setBlockState(p_176491_2_.offsetUp(), this.getDefaultState().withProperty(HALF_PROP, BlockDoublePlant.EnumBlockHalf.UPPER).withProperty(VARIANT_PROP, p_176491_3_), p_176491_4_);
}

public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack)

public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack)
{
    // Replaced this
    //worldIn.setBlockState(pos.offsetUp(), this.getDefaultState().withProperty(HALF_PROP, BlockDoublePlant.EnumBlockHalf.UPPER), 2);
    worldIn.setBlockState(pos.offsetUp(), this.getDefaultState().withProperty(HALF_PROP, BlockDoublePlant.EnumBlockHalf.UPPER).withProperty(VARIANT_PROP, worldIn.getBlockState(pos).getValue(VARIANT_PROP)), 2);
}

Notes:

• The rendering for double plants needs to be changed as well as the upper part can now determine its type indepently.

• This change will not affect already placed double plants. Some kind of updating method is needed to give all upper parts the correct meta data based on the block below it.

Isn't this part of MC-1874 rather then related?

Confirmed for 1.9.3-pre3

@unknown, the part

top of double plants (always peony) (breaking, not completly destroying (sword in creative)) (MC-29590)

describes this bug and is probably unrelated to the other situations described in MC-1874

I added that...

Still in 16w21b

Still in 1.10-pre1

Still in 1.10