mojira.dev
MC-33398

statistics - thousands separator and decimal mark are both commas

1*,*000="thousand"
1*,*0="one point zero"

both have commas as separation mark, can be confusing!

It doesn't matter how small the bugs are...
But they must be fixed!

keep up the good work

Linked issues

Attachments

Comments 7

Cannot reproduce in the latest version of minecraft (13w48b). I will reopen if you confirm you are still seeing this issue.

I'm also seeing this bug. I don't have a save in a recent version of minecraft to show though.
This is probably caused because you use commas for the thousands and use the system locale for the decimals. Try changing your OS' locale (not the minecraft language) to one that uses commas for the decimals (like Greek) and you'll see it.

Hey, I remembered of this issue now. I've noticed this in the statistics screen, and then I remembered of seeing something about that in the bug tracker. This is still happening, can anyone reopen?

I have confirmed this issue in 1.11.

There are two bugs:

  1. decimal places are formatted using the system (JVM) locale instead of the language set in Minecraft

  2. grouping separators (thousands place) is always formatted with a NumberFormat.getIntegerInstance(Locale.US), hard coded.

To replicate this bug you can override the system (JVM) locale to French with these arguments on the command line:

-Duser.country=FR -Duser.language=fr

In all cases, the system (JVM) language should be ignored and the Minecraft language should be used for formatting.

With English language in Minecraft, and French system language, numbers should be formatted like this: "1,000,000" and "1.00" but they show up with the format "1,000,000" and "1,00" instead.

With French language in Minecraft, and English system language, the numbers should be formatted like this: "1 000 000" and "1,00" but they show up with the format "1,000,000" and "1,00" instead.

When this issue is fixed, the French non-breaking-spaces will be used properly and it will expose this bug as well: https://bugs.mojang.com/browse/MC-2595

Finally someone reopened this issue.

"In all cases, the system (JVM) language should be ignored and the Minecraft language should be used for formatting."
Not sure that is the correct way, at least I would like the opposite to happen. System locale is changed by the user to something he is accustomed with, just because someone plays the game in a different language it doesn't mean the number format should also change. For example I played the game in English but I'd prefer the numbers to appear using my system format which is Greek,

Anyway whatever format is used the issue here is that it should be consistent on all the places where numbers appear.

In snapshot 16w50a the behavior is different but still incorrect:

Every number format is Locale.US style and ignores both the system (JVM) language and the Minecraft language.

When the Minecraft language is set to French it should display numbers like "1 000 000" and "1,00" but instead it uses the US style "1,000,000" and "1.00".

This issue was actually fixed in 16w50a (see this comment)

AgentM

(Unassigned)

Unconfirmed

comma, decimal, locale, statistics

Minecraft 13w39b, Minecraft 13w43a, Minecraft 1.7.1, Minecraft 1.7.2, Minecraft 1.11, Minecraft 16w50a

Retrieved