mojira.dev
MC-3416

Player location marker invisible on map (wrong Z-Order). One-line fix included.

we had a survival map for quite some time, when maps were able to be duplicated we decided to make maps for both of us (there are only two people on the server) it worked fine until item frames were added, then we wanted to make waypoints on our map using more duplicate maps and item frames. duplicating done with an empty map.

when we put the first two maps in the item frames it worked fine, but on the third extra map we noticed it didn't make a green arrow on our map. so taking it off and using the other version of the map in my hand made the green arrow appear. but then I "fell" through the map myself, so I quickly swapped back with the map on the frame, I broke the frame but the arrow stayed, however i was still not on the map. i later walked into an uncharted area to see myself for a second or two under the terrain being charted.

Steps to Reproduce:
1. duplicate a large map use the duplicate to make more copies (I think the issue lies here)
2. put the maps in various item frames around a world, we put ours in the villages we found.
3. you will notice on the 5th active map (there was me and my friend with maps on at the time, as well as two maps already working perfectly) will not show on the item frame, the actual map will be there, but not the green arrow. like I said through experimentation I noticed that the arrow still existed it was just under the terrain.


One line fix by @unknown can be found in this comment

Related issues

Attachments

Comments

migrated
[media][media][media][media][media][media][media][media][media][media][media][media]
migrated

they didn't involve as much info though, eh as long as its fixed πŸ™‚

migrated

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

migrated

Still present in version 1.5

Are there any plans to resolve this? I think it is a major impediment to widespread map usage.

migrated

On this OSX, playing version 1.5.2, you can see some z-fighting while tilting the map; the hidden markers flicker to view (see attached images).

migrated
  • 13w25c SMP Windows7,Java7,64-bit

  • 3 rd copy at scale 1:2, never changed scale during copies

    • the other two hung in frames, green pointers show correctly

      • hung inside the map range

  • noticed after server restart

  • white pointer is drawn between paper and map pixels

  • MC-3416_z-order.png: upper right is the round white pointer

migrated

Still a problem in 1.6.2, only 3 copies, but I ran all around the borders to fill it in. Different (smaller) map still shows arrows.

migrated

This problem still persists in the latest snapshot 13w38c, and is especially important to fix now, Because framed maps are now able to be stitched together and look so cool, people will want to use them more. However, with this bug, they are unusable in SMP.

migrated

I decided to comment on this issue to increase the chance of a fix.

After hours stitching together 8 of the almost-fully zoomed out maps to prevent myself ever getting lost, and making sure I carry around maps so that I don't get lost, I am now lost. I'm not entirely surprised though: I can recall that maps have always been buggy, always had just that little problem that made them frustrating and time consuming experience, and it's these little bugs that have meant I've just stayed away from even making maps - it seems every time I come back to them they're just that little bit closer to being useable, but still not quite there yet.

Over the years you've put in a lot of effort into getting maps working and looking great, and it's appreciated. But all that work is for nought if the maps can't even help you find your way around. Please fix this one last thing to make maps as awesome as they should be - I have a beautiful wall map back at base and Steve needs your help getting there.

Version: 13w41b
OS: Linux Ubuntu

migrated

dddeeeffff, I wanted to comment to let you know it is possible to work around the map bugs. I don't want to minimize them, and I too am really hoping that both major map bugs will be resolved, but in the mean-time try these work arounds:

1) This bug is caused by having maps in both item frames and in player hands. It doesn't seem to happen if maps are only in item frames, or only in player's hands. So my work around for this bug is to separate the two: I have two sets of maps, one for players and one for walls. I have a script that runs when the server is offline that copies the versions in player's hands to the ones that go on walls. Here's my current copymap.bat:

copy /y world2\data\map_0.dat world2\data\map_10.dat
copy /y world2\data\map_1.dat world2\data\map_11.dat
copy /y world2\data\map_2.dat world2\data\map_12.dat
copy /y world2\data\map_3.dat world2\data\map_13.dat
copy /y world2\data\map_4.dat world2\data\map_14.dat
copy /y world2\data\map_5.dat world2\data\map_15.dat
copy /y world2\data\map_6.dat world2\data\map_16.dat
copy /y world2\data\map_7.dat world2\data\map_17.dat
pause

In the above batch script, I copy maps# 0-7 to 10-17. Maps 0-7 are in player's hands, maps 10-17 are on walls in multiple locations. This seems to work well, and works around this issue.

2) The above doesn't fix the other major map bug, MC-32480. However, that bug can be resolved by completely quitting minecraft when you disconnect from the server (in MP) or reload a map (in SP)

Hope this helps!

migrated

http://picpaste.com/2013-10-14_19.46.31-UaxEyc8D.png
Thanks! Restarting the server made the things come back long enough to find my way home. I'll give some thought to the fix you outlined, but it'll require some head-scratching to work around the various maps that are already in existence, something I don't have all that much time for

migrated

I have had a similar issue with large maps in a single player world I created. I don't know if it may be related to the number of chunks that are loaded or what. But I created three large maps in a row, and found that each of my maps stopped functioning once I went off the frames after creating them. I tried just exit to the start menu then loading the world again from there and they were still nonfunctional. But once I exited the entire program and reloaded it from the launcher, the maps worked again.

Could a way to update/reload/refresh maps, maybe an F# key or something, even possibly a function that runs when a player switches to a map? Just a thought.

I am currently running the 1.7 prerelease.

migrated

Pretty sure this has nothing to do with the number of players. I constantly have to restart minecraft from scratch to start showing my position on the map correctly. Not sure what causes it but it happens multiple times every time I play. I have maps in frames as well. Always works after a fresh start but stops after using the map or possibly after making new maps. Wish I could nail down why it's happening as having to restart minecraft from scratch gets annoying. Running 1.7 pre - release. Win7, latest java.
Aaron's suggestion for a map refresh option would be VERY helpful.

migrated

Problem exists still in 1.7.2.

migrated

Problem still exists in 1.7.3.

migrated

Confirmed for 1.7.4.

Can this please be updated?

Ezekiel

Is this still a concern in the latest Minecraft version 14w05b? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

migrated

Still a problem in 14w07a

migrated

Still a problem in 14w11b.

migrated

ProblemΒ still exists in 1.7.9

migrated

Still messing with our already low orientation skills in 14w30c.

migrated

Still in 1.7.10, just in case someone thinks it went away at any point.

migrated

This is a bug that has occurred for a long time and has made a nice feature of this game nearly unusable. I would think that the fix would not take much time, once isolated, and would make maps very useful once again. I hope someone can look into this and see if it's as simple as I think and restore one piece of maps' usefulness.

migrated

This bug (which is indeed still present in 1.7.10) arguably defeats most of the purpose of having maps. Some way to mark locations of interest is necessary, since almost nothing of interest can possibly be visible on the held map item at the highest zoom level (the only one that's really useful for navigation).

migrated

Still present in 1.8 pre-1. I'm sure this will be fixed by 1.8 pre-2. πŸ˜‰

migrated

@unknown: Guess again πŸ™‚

Affects 1.8-pre2.

migrated

To the people in power to fix the bug:

This z-order issue has a one-line fix in the official equivalent of MCP's src/minecraft/net/minecraft/client/gui/MapItemRenderer.java:

In the last line of the loop where the icons are added, there is a variable that is increased (++var6; in MCP). Decrease this instead (--var6;) and the z-order will go in the right way:

[media]

Edit: If you want to fix this for yourself in 1.7.10, open the file bbz.class in a hex editor and at the offset 0x967 change 84 06 01 to 84 06 ff. (Usual modding requirements like a using a custom version and deleting META-INF apply.)

migrated

Altti, that is awesome!!! If they don't fix it in 1.8, could you please post an equivalent once it comes out?

migrated

@unknown: It's a bit harder because the right class file will be unknown, but it should be possible.

Edit: In 1.8-pre2 it's offset [email protected], 84 07 01 -> 84 07 ff

Edit2: Affects 1.8-pre3, the offset above seems to be the correct one to fix it for 1.8-pre3 too.

migrated

Altti, thanks so much! I played for a few hours yesterday on 1.8-pre2 with your patch, and it worked great!

This seems like such an easy fix for Mojang – hopefully someone there will notice. If there are any mods out there that know how to get Mojang's attention, this seems like it would be worth it!!!

migrated

Currently experiencing in 1.8 pre 3

Second map placed in item frame did not want to display green arrow. (temporarily) Placed additional map, second green arrow showed. Placed third map, no green arrow, and player arrow dissapeared. Placed up to 5th map. No green arrows other than first two

Exited game came to report bug. After reading (before publishing post) loaded up world again, player arrow is back, only 5th green map arrow appears (not #1-4)

migrated

Affects version 1.8

For those who want to implement the fix: Change offset [email protected] from 84 07 01 to 84 07 ff. Linux and Mac users can use this installer to fix it.

migrated

Well, Altti, you've really handed it to Mojang on a silver platter. I've been waiting for a fix for this for... has it been years? Patch seems to work well.

If you're ever visiting Oregon, pints are on me.

migrated

Can anyone tell me how to implement this fix for a windows client?

migrated

I'm far from an expert on this, but in Windows:

1) Go to %appdata%\.minecraft\versions
2) Copy the 1.8 folder and rename it something new. I used '1.8 mapfix'
3) rename 1.8.jar to 1.8 mapfix.jar and 1.8.json to 1.8 mapfix.json
4) open 1.8 mapfix.json (with a text editor) and edit the id line to be 1.8 mapfix, save changes
5) edit the .class file (inside 1.8 mapfix.jar) with a hex editor as Altti described and save it. Don't forget to delete META-INF (I did, thanks Dolphin)

1-5) Now handled by Altti Tammi's installer script
6) start up minecraft with the launcher and edit your profile, you should see a new version available for selection called 1.8 mapfix, use that.
7) enjoy working maps

If anyone has any corrections or issues with my post let me know and I'll be happy to edit/remove it as needed. Thank you Altti for the solution and for the installer.

Edit: Corrected missing META-INF deletion (thanks Dolphin). Crossed out old method, I suggest using the installer for simplicity.

migrated

@unknown: I added a Windows installer script (PowerShell, comes with at least Win7) and some instructions too.

(@unknown's instructions are correct (apart from the missing bit about deleting the manifest), the script automatizes parts 1-5 in his instructions. You'll have to edit the profile yourself.)

migrated

One extra point for newbies for step 5 in Michael's instructions is to be sure to delete the META-INF inside the jar. Altti, I assume your script does that? If so, your script might be the best route for those unfamiliar with patching. Thanks for sharing it!

Edit: After reading the script, it appears it uses the "jar" program to do the update rather than a zip program, so while META-INF is not deleted, the checksums should be updated. Correct?

Also I do have one other question: In a server environment, is this fix only needed on the client side, server side, or both? I think it is client only, but I just want to verify. Thanks!

migrated

@unknown: The flag M for jar tells it to remove the manifest (META-INF). And good call, that part is necessary for any modding. The bug (and the fix) is client-side only.

migrated

For those of us not fluent with windows PS, could someone walk me through what to do so I don't delete my c drive? All the help is really appreciated.

migrated

@unknown: The script doesn't need any input and fluency in PS isn't necessary (unless you want to verify the script doesn't delete your c drive, which at least someone should! πŸ™‚). First download the script from this link with Save as. If your system is configured to allow running scripts you could just double-click it, but I wouldn't count on it. Instead, open the Run dialog (Win+R) and enter, changing the path if necessary (this one is for the Downloads directory in your home directory):

powershell.exe -ExecutionPolicy Unrestricted -File "%UserProfile%\Downloads\mapfix_installer.ps1"

(Windows might then give scary warnings about how you shouldn't do what you are just about to do, because they think scripts are somehow more dangerous than other executables.) Remember to change the version (Edit profile) in the launcher.

migrated

When I run the script, I get a bunch of errors: http://pastebin.com/2HNZe0e2

migrated

Too bad. It seems like the jar program that can manipulate the .jar files only comes with the Java JDK, not the JRE that is required for Minecraft. I was hoping there was a way to do this on Windows without any external dependencies that aren't installed by default, but apparently not. I almost certain I can't redistribute just the jar.exe and Oracle doesn't have a separate download for it, so for now downloading the JDK is the only option.

Edit: There is now an option to use the command line version of 7-zip for those who don't want to download and install the whole JDK.

migrated

Still a problem in 1.8.

migrated

It appears that this bug is still present, (I made this post quite a while ago, close to when maps came out) and I feel if we could let mojang see how far the thread has come, we would potentially get results. (Shoutouts to Altti for the patch!)

migrated

@unknown: It's amazing this bug has been left virtually unseen by Mojang for almost two years now and it seems like it won't be fixed in 1.8.1 either. The fix would be so easy, if only someone would look at this for a few seconds.

Oh yeah, affects version 1.8.1-pre1.

migrated

It's a small bug, but it affects maps and makes them nearly useless after a while in-game. It affects all systems and has been present since maps were updated, as far as I know. It would be a simple fix, and I really hope someone considers looking into it soon.

migrated

Affects 1.8.1-pre3.

migrated

Note: this is NOT vanilla (I applied Altti's one-line fix), but illustrates my point.

migrated

I just found out something...

Altti's one-line fix does ensure that all arrows are displayed, but it doesn't resolve the real underlying issue - why there are so many arrows. After some experiments, it seems to me that whenever a chunk is unloaded and loaded, all item frames in that chunk will have their corresponding green arrows duplicated.

I realized that because after using Altti's one-line fix, we had a map (of the hell) where the arrows piled up like... can't describe it, see screenshot.

migrated

@unknown: This is actually another bug, not an underlying issue to this one. The wrong z-order and your marker duplication are equally bad, but I think your find would warrant another bug report. I'm not sure if it can be accepted as you are playing a modded game. It's still worth a try I suppose. Your image made me think about a map I have ingame and explains perfectly why a certain marker looks "3D" in the item frame - there are a lot of duplicates stacked, though not as many as you have.

No wonder why in vanilla I have had maps that show only one marker without the patch, even though there was just one copy on a wall and one on me - the one on the wall must have been duplicated.

migrated

Affects 1.8.1-pre4

migrated

In vanilla, you might be able to see the markers stacking out behind the frame

migrated

@unknown: I submitted the marker duplication as MC-74153. @unknown: You guessed correctly, they can be seen behing the frame (see mentioned bug), which proves the cause for this bug too - markers are being offset in the wrong direction.

migrated

Affects Minecraft 1.8.1-pre5

migrated

Affects Minecraft 1.8.1

migrated

In 1.8.1 the bug can be fixed at offset [email protected], change 01 -> ff. I updated the installer for the fix to include 1.8.1.

migrated

Same problem in 1.8.1 with vanilla and default ressource pack, sometime marker appear in back of map, I can only see it on border of map

migrated

BUG: Marker behind map

Moesh

Can confirm this bug is still present. Confirmed via picture. Multiple players on the map, but rendering below the map area.

Moesh

Player dots are rendering below the map area--anything above four players is rendered under the map.

migrated

Affects 1.8.2-pre5

migrated

Is anyone ever going to correct the grammatical errors in the title of this issue? It is a serious issue that affects maps in the entire game and should have wording that doesn't look like an eight year old is complaining about a minor issue.

Also, given that there is already a solution to the issue that requires modifying the game code, if this were brought to the attention of a Mojang programmer they could have it fixed in minutes.

migrated

Affects 1.8.2-pre6

migrated

Hooray, fixed at last, am almost a little bit sad, end of an era (an era being approximately how long it took this to get fixed πŸ˜› )

migrated

Since I'm new and not sure were my comment belongs, I'll copy my comment from MC-73 here: I'm still having this problem in Version 1.8.8. A copy map placed in an item frame has green marker when removed and doesn't display current location marker. It goes away when I exit the game and come back, but it's annoying. This issue feels more similar to MC-73 but I noticed people being redirected here, so here I am.

Zitchas

LIke Gianna, I notice a lot of different threads, many of which match my bug more closely than this one, but they all redirect here.

Anyway, I have a map which I put on the wall in an item frame. Then I took it off the wall, and it still shows the green arrow marking where it is on the wall. I did this with two different locations on the same map, and the green arrows for both are still there.

Zitchas

note: I am running 1.9.2 vanilla, so the bug is present there.

migrated

Still present in 1.10.2
A map placed in an item frame and then duplicated no longer shows the player location marker on the map. It only shows the green marker.

migrated

Sounds like a different issue.

migrated

That's what I thought a year ago, but everyone was being directed here. Should I make a new post? Or is there somewhere I should be redirected to?

migrated

Reopened. Does it also affect 16w40a?

migrated

I haven't been able to thus far.

migrated

Last time I messed around with maps (in 1.11.2) this was still an issue - If what I was experiencing was the same issue or related. Here's how I'm seeing it:

I make a map, zoom it out a few times, and put it in a frame that is located within the mapped area. A green marker appears but the player position marker stops working (or isn't rendering correctly?), even on copies. For me, this hasn't been an issue if the map in question is positioned in a frame outside of the mapped area.

Basically this means that when I make my big "mega map" (many zoomed out maps framed next to each other on the wall) and position it in my base, I can continue to use copies of those maps for exploring, but only really for exploring those areas far from my base (i.e. not included in the map area in which the maps are framed). It also means I can't give my friends copies of these maps to frame at their bases, unless I want the maps to be much less useful for exploring the areas around their bases as well. Ditto for villages, temples, etc...

Maps would be so much more awesome if this weren't an issue. I have a good memory so I can kind of remember where things are anyway, but it would be much handier if I could make use of those little thumbtacks to point to important locations.

... p.s. This would have been an excellent candidate for a fix in the Exploration Update. Too bad! Useful colored map markers for the World of Color update? πŸ˜ƒ

metaed

Encountered what looks like the identical bug in MCPE 1.1 (Android).

migrated

This project is for the java edition only.

migrated

Got the same thing happen in 1.12.1.
After placing a map into item frame and breaking it several times the green stationary marker stopped appearing. The white player marker is still working.

[media]

[media]

migrated

@Vindicar Can you elaborate? Did you just left click the map out of the item frame, or break the item frame altogether? Is this bug reliably reproducible?

This bug report is in a bad state because the current description does not fit the current bug. It's a different bug with the same syndrome.

violine1101

I am closing this report; the issue this ticket was about when it was created appears to have been fixed ages ago.

For any kind of player marker not appearing on maps in frames, go to MC-126810.

If you still experience this issue, please create a new report (unless someone else already has). This ticket is a mess currently.

migrated

(Unassigned)

Community Consensus

item-frame, maps, rendering, z-order

Minecraft 1.4.4, Minecraft 1.4.5, Minecraft 1.4.7, Minecraft 1.5, Minecraft 1.5.2, ..., Minecraft 1.8.2-pre4, Minecraft 1.8.2-pre5, Minecraft 1.8.2-pre6, Minecraft 1.10.2, Minecraft 1.12.1

Minecraft 1.8.2-pre7

Retrieved