Chest not spawning in Monster dungeons

I spent 3hrs to fix this bug 🙂
source code: https://gist.github.com/menangen/41f3fa26c06b3bde9c8c
Compiled class:
https://dl.dropboxusercontent.com/u/20454826/minecraft-distribution/java/atn.class

I noticed this yesterday, but didn't realize it was universal. I was testing Spectator Mode's no-clip, noticed a dungeon, and went in. Only a spider spawner, nothing else. Here's to hoping it gets fixed soon.

I found the same bug. I think it might have something to do with the new blocks.
I added a pic so you all can see it. I removed the sand before I took it.
Seed: -1718923230
location: 1145 64 -142

I can confirm this bug too in 14w05a. No chest whatsoever in dungeons. This has been broke since 14w04a? Ugh. I guess I shelf the snapshots until this nasty one is fixed.

The latest snapshot,14w06a,is also affected by this issue.
Hope this bug will be fixed soon,'cause im planning on starting a new world but i wont until it is fixed.

Here is another example:
Version 14w06b
Seed: 2126315972428485332
@ xyz 32 30 277

Generated with no chests.
Use this seed in version 1.7.4 a Chest will be there.

I created two test worlds in 14w06b and searched out five dungeons in each using specatator mode. No chests in any of them. Seeds are: 1612121720 and -674343923. I didn't save the coords for the dungeons, except for the last one where I was at when I stopped searching. It's in -674343923 and the coords are: -4967 22 -499.

Ok, two more snapshots with tons of fixes and enhancements and this is still not fixed. How are people going to want to start new worlds or even venture out in an existing world when they know any chunks generated will have completely broken dungeons in them? Come on Mojang. You can't leave existing core functions of the game broke and expect us to want to test out your new stuff. This needs to get fixed. Next snapshot. Some guy above says he fixed it and I assume he doesn't work for Mojang. I am not going trust his fix but I think the point here is made.

Screenshots: same dungeon from 14w06b generation (spectator mode) and 1.7.3 generation (creative mode)

Same problem, after about the 5th or 6th dungeon found without a chest I figured it was more than just unlucky coincidence

Thank god this is a bug, I thought I just had the worst seed ever! Thing is I'm already fairly established in my new world and I have found plenty of empty spawners, tempted to restart but I don't wanna have to do it all again!

This bug is unacceptable IMO. Yeah, you don't want to venture out in your current world because of it. The enjoyment of dungeon hunting is a total waste. Starting a new world is useless too unless you want to go back 1.7.4. 5 or more snapshots with it and this bug is alive and well.

Chill, Adam.

First of all, these are snapshots, not polished releases, or even prereleases. If people, for whatever reason, choose to upgrade a publicly-facing server to what is admittedly a potentially unstable version of Minecraft, the only warranty is that if it breaks they get to keep the pieces.

Second of all, believe it or not, Minecraft's underlying engine is currently going through massive refactoring under the hood. Minecraft's code has historically been tightly coupled between systems which makes the entire engine very spaghetti-like, and certain refactors may thus cause bugs because we can't always predict every single side effect of decoupling these systems and making them more robust. In this case, it was a simple typo from writing "pos" instead of "chestPos" on one single line when condensing four blocks of more or less identical code into one - an easy oversight to make, one which doesn't remotely deserve the level of invective which you are showing.

Thirdly, we don't have a QA group. That's more or less what this site and the weekly snapshots are for in the first place. Testers do not dictate the time frame over which bugs are fixed, the developers do, and sometimes the developers have very good reasons for giving a given bug short shrift in favor of other bugs or other code refactoring. To that end, I am so very sorry that it took a whole three and a half weeks for me to have the spare time to look into and fix this issue, and that I spent my time fixing the numerous crashes and visual bugs that my refactoring of the block model system caused instead.

The people downloading these snapshots are your QA group. That is fine. And of course work in progress code has bugs. It just seemed a very long time to fix, as you have indicated, a one line code change. I know there are priorities and I guess given the other issues, this would be lower than those. I guess the grain of salt to rub in with 1.8 snapshots is that stuff out-of-the-blue is going to break that has worked fine for many releases. To be honest I have reported many bugs and not gotten particularly upset about them (except one but that was my bad and I admitted it). This one made me stop being a QA tester and enjoy the game at the same time. I stopped playing it altogether. I want to see the new stuff and I totally understand if the new stuff is broken at first. But I was not prepared for old stuff like this to be broken too.

BTW, you can lay off on the condescending attitude I’ll lay off on riding Mojang for poor snapshot bug turnarounds. Deal?

Finally located this bug listing for this issue, and I'm encouraged to see it fixed come the next snapshot. Interesting that one typo in the code can do this, but I know coding too, so that's totally possible to happen, especially when you're talking about over a million lines of code!

Great job! Let's knock out all them bugs!

@Mog:
Didn't realize you posted this in the bug site itself. OK here is my reply also public:

The people downloading these snapshots are your QA group. That is fine. And of course work in progress code has bugs. It just seemed a very long time to fix, as you have indicated, a one line code change. I know there are priorities and I guess given the other issues, this would be lower than those. I guess the grain of salt to rub in with 1.8 snapshots is that stuff out-of-the-blue is going to break that has worked fine for many releases. To be honest I have reported many bugs and not gotten particularly upset about them (except one but that was my bad and I admitted it). This one made me stop being a QA tester and enjoy the game at the same time. I stopped playing it altogether. I want to see the new stuff and I totally understand if the new stuff is broken at first. But I was not prepared for old stuff like this to be broken too.

BTW, you can lay off on the condescending attitude I’ll lay off on riding Mojang for poor snapshot bug turnarounds. Deal?

TL;DR : We dont have a friggin QA group, but the people who test our snapshots ARE the QA group now. Its so easy to mistake ChestPos for Pos and they didn't even notice. Adam wasn't prepared for the out-of-the-blue stuff around here, but he is feeling sorry.

I rebuilt a new map, same seed. The previous empty dungeon now has chests. This bug is confirmed FIXED in 14w07a

14w07a snapshot. 2 desert dungeons without spawners and chests. (See the 2 screenshots above)

I still havent found an underground dungeon yet,cause i just started the world a few hours ago and i havent done any caving yet.Because im using /gamerule natural Regeneration false and im a bit scared. 😛

I will keep updating if i find some more.

Seed.

Yes,sorry,i forgot about that.

Alright, so what's the seed?