Ice with non-solid blocks below them doesn't create water when mined by players

The Bug:

Ice with non-solid blocks below them doesn't create water when mined by players.

Steps to Reproduce:

1. Place down some ice and ensure that there's air below it.

2. Break the ice.

3. Take note as to whether or not ice with non-solid blocks below them doesn't create water when mined by players.

Observed Behavior:

No water is created.

Expected Behavior:

Water would be created.

Code Analysis:

Code analysis by @unknown can be found below. An additional code analysis by @unknown can be found in this comment.

The following is based on a decompiled version of Minecraft 1.19.2 using MCP-Reborn.

net.minecraft.world.level.block.IceBlock.java

public class IceBlock extends HalfTransparentBlock {
   ...
   public void playerDestroy(Level level, Player player, BlockPos blockPos, BlockState blockState, @Nullable BlockEntity blockEntity, ItemStack itemStack) {
      super.playerDestroy(level, player, blockPos, blockState, blockEntity, itemStack);
      if (EnchantmentHelper.getItemEnchantmentLevel(Enchantments.SILK_TOUCH, itemStack) == 0) {
         if (level.dimensionType().ultraWarm()) {
            level.removeBlock(blockPos, false);
            return;
         }

         Material material = level.getBlockState(blockPos.below()).getMaterial();
         if (material.blocksMotion() || material.isLiquid()) {
            level.setBlockAndUpdate(blockPos, Blocks.WATER.defaultBlockState());
         }
      }

   }
   ...

If we look at the above class, we can see that there are two checks that are carried out before allowing ice blocks to be converted into water upon being mined by players. One of these checks is to make sure that the player isn't holding an item enchanted with silk touch at the time of the interaction, and the other is to check if the material below the ice block blocks motion or is a liquid. Because of the material check that's in place here, when ice with non-solid blocks below them is mined by players, it doesn't create water, therefore resulting in this problem occurring.

Fix:

Simply removing the material check within this piece of code before allowing ice blocks to be converted into water upon being mined by players will resolve this problem.

Current Code:

...
Material material = level.getBlockState(blockPos.below()).getMaterial();
if (material.blocksMotion() || material.isLiquid()) {
   level.setBlockAndUpdate(blockPos, Blocks.WATER.defaultBlockState());
}
...

Fixed Code:

...
level.setBlockAndUpdate(blockPos, Blocks.WATER.defaultBlockState());
...