mojira.dev
MC-767

Creating world with seed and map world "QUATREPOINTDEUX" fails

What I expected to happen was...:
Create a new world with the name "QUATREPOINTDEUX" without quotes and the seed "QUATREPOINTDEUX" without quotes.

What actually happened was...:
There is the normal generation screen with the mentions "Loading world" and "Converting world" but nothing happens after. I mean the game stops at this screen.

Steps to Reproduce:
1- Click on "Singleplayer"
2- Click on "Create a new world"
3- Write QUATREPOINTDEUX as the World name
4- Go to "More world options" and type QUATREPOINTDEUX as seed.
5- Click on Create new world.

Related issues

Attachments

Comments

migrated
[media]
migrated

I can confirm that the client does in fact appear to lock up. The save directory is created. I killed the client to see if I could play the world. I select it in single player and it sticks on loading... This is an odd one.

migrated

Confirmed. I too had to cancel the "javaw" task when trying to create a world with that seed. The name of the world can be anything. The seed is the problem point here.

migrated

I'm gonna look into it in MCP. And try to fix it.

EDIT: When server is trying to generate world with seed "QUATREPOINTDEUX", it throws an exception and stops. But client doesn't get notified about it, and continues waiting for messages from server. Now I "just" need to find out why server crashes.

migrated

Confirmed again.

Had to close the proces with task manager.
Where did you got the seed from.
Needs to be fixxed, before people go start abusing them, as trolling in a server.

migrated

A member of my french community has reported it. I think it's just a random seed his wanted to try since it means something "real" in french.

migrated

The problem was happening when there was no valid position to place a stronghold (they can only be placed in certain biomes), and possibly in some other cases. I fixed it be changing 1 line in the code. I'll recompile and reobfuscate it later.

@mojang That'SSSsss a nice typo you have there. It'd be a SSSssshame if SSSsssomething happened to it (i.e. it was fixed) 🙂
First you are doing

int[] cache = IntCache.getIntCache(xSize * zSize);

and then

for (int i = 0; i < cache.length; i++)

But cache.length can be larger than xSize * zSize. When i == xSize * zSize, cache[i] == -1 and biomes[cache[i]] will throw ArrayIndexOutOfBoundsException.

Second piece of code should be

for (int i = 0; i < xSize * zSize; i++)

Nathan Adams

Thanks for the help.

migrated

So is this fixed?

migrated

Dinnerbone resolved the issue as fixed, so I'll assume that it is. 🙂

migrated

Is MC-707 the same bug? Sounds very similar.

migrated

A mod that fixes this bug.

migrated

Yes, it's the same bug.

BTW, I attached the mod that fixes it (ye.class) in case someone wants to use these seeds, but doesn't want to wait for the snapshot.

migrated

This question may be out of place here, but I tried replacing the ye.class file in minecraft.jar using 7zip and when I try to log in, it crashes with:

java.lang.SecurityException: SHA1 digest error for ye.class
at sun.security.util.ManifestEntryVerifier.verify(Unknown Source)

You can't simply swap out the file?

migrated

Did you delete the META-INF?

migrated

No, I'll try to find it.

migrated

Nathan Adams

Unconfirmed

Minecraft 1.4.2

Minecraft 1.4.3

Retrieved