Note blocks: Gray color for certain music notes

Confirmed

Up to Minecraft 1.8.1 the note symbols were always colored, since 1.8.2 there are certain gray colored notes.

I think it's the color green which has become gray.

Confirmed for

• 1.8.6

It seems like (nearly) all colors are incorrect, according to the wiki note 0 for example should be green

Please mention somewhere in this report "Note block" and also add labels
Thank you

Can be reproduce for example with the following command:

/particle note ~ ~1 ~ 0.08333333333333333333333333333333 0 0 1

This should equal the second note.

Please link to this comment in the description

The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.

The reason why this happens seems to be that the method net.minecraft.client.particle.EntityFX.renderParticle(VertexBuffer, Entity, float, float, float, float, float, float) was changed in a way that it now sets the color differently. I am however not too familiar with what the methods do and how the rendering is done so I am unable to tell what the exact reason is.

Confirmed for 17w17a. I know this isn't high-priority, but since the upcoming update is 'World of colour' and note blocks have been worked on, perhaps it's time to bring back the vibrantly-coloured note particles.

Still happen on 1.13

Still happens in the latest snapshot (19w09a).

If I had to guess what causes this problem, I would say it's because the formula for calculating the note colors sometimes returns negative values.
Maybe the particle rendering code change in 1.8.2 made it no longer like negative colors.
In that case the easiest way to fix it would probably be changing the color formula in the particle class.

It would be really nice if this was fixed before 1.14 comes out with the new instruments. Cheers!