mojira.dev
MC-87989

Wrong line when casting fishing rod in third person view

The bug

When casting a fishing rod for the first few ticks the line connecting the rod and the hook is pointing away from (0|0|0).

The reason

The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.

The reason why this happens is that the public void func_180558_a(EntityFishHook p_180558_1_, double p_180558_2_, double p_180558_4_, double p_180558_6_, float p_180558_8_, float p_180558_9_) method of the net.minecraft.client.renderer.entity.RenderFish class uses the fields prevPosX, prevPosY and prevPosZ of the fishing hook to render the line. However until the fishing hook is not updated, its prevPosX, prevPosY and prevPosZ fields are all 0d. This could be solved by setting them all to the current coordinate values in the constructor. In general it might make sense to do this for all entities.

Linked issues

Attachments

Comments 6

[Mod] redstonehelper

A similar issue was fixed recently. Is this still an issue in 15w44b? If so, please explain the issue in detail and provide steps to reproduce it. Please also update the list of affected versions.

marcono1234

Confirmed, please reopen

SunCat
marcono1234

MC-90070 rather duplicates this report as this one here is older, but it is indifferent anyways, both reports contains nearly the same information

user-f2760

switched them around

SunCat

In any case, still in 1.9

marcono1234

migrated

Confirmed

casting, fishing_rod

Minecraft 15w36c, Minecraft 15w47c, Minecraft 1.9, Minecraft 16w35a

Minecraft 16w44a

Retrieved