[MC-96526] Crash caused by StackOverflowError when trading too many items at once

This report is based on MC-34943

The bug

When you have a villager trading an item for an item with the Count of 0 and you Shift-click on the trade when you have a empty inventory, Minecraft crashes.

How to reproduce

Use the following command

/summon Villager ~ ~1 ~ {Health:0.1f,Offers:{Recipes:[{buy:{id:"stone",Count:0b},sell:{id:"dirt",Count:1b},maxUses:2147483647,uses:0}]}}

Empty your inventory
Give yourself one stone block
Place the stone block in the trading window and Shift-click the offered item (dirt)

Attachments

crash-2016-02-03_21.21.15-client.txt

crash-2016-03-07_21.25.50-client.txt

Comments 10

Bren Rado 2016-02-07T18:57:34Z

Confirmed for 16w05b

SunCat 2016-03-07T12:59:24Z

Confirmed for 1.9

SunCat 2016-03-12T17:03:03Z

Still in 1.9.1-pre3

SunCat 2016-04-13T21:14:51Z

Still in 16w15b

marcono1234 2016-04-23T18:13:15Z

Probably "Invalid"

Normal villagers can only trade 64 items at once and there this bug should not occur

SunCat 2016-04-27T16:53:56Z

Fixed for 1.9.3-pre2! Stops at full inventory without 32 items.
Edit: still in -pre1

marcono1234 2016-04-28T12:07:48Z

The exception is still printed to the Game Output but I guess that is not such a big problem

user-f2760 2016-04-28T12:17:04Z

@unknown perhaps a different report will do.

marcono1234 2016-04-28T21:05:47Z

I don't think using items with count of 0 results in a valid report

user-f2760 2016-04-28T21:35:12Z

Nevertheless, the game should not print an exception, and this report (which also has a count tag of 0) was also a valid report.