Firework explosions don't damage ender dragons, end crystals, boats, minecarts, paintings, item frames, or leash knots

The bug

Firework explosions don't deal damage to numerous amounts of entities.

Affected entities

• Ender dragons

• End crystals

• Boats

• Minecarts

• Paintings

• Item frames

• Leads

How to reproduce

1. Obtain a crossbow and some fireworks

   /give @s minecraft:crossbow
   /give @s minecraft:firework_rocket{Fireworks:{Flight:1,Explosions:[{Type:1,Flicker:1,Trail:1,Colors:[I;12801229],FadeColors:[I;11743532]}]}} 64

2. Load a firework into the crossbow

3. Summon one of the affected entities listed above

4. Take note as to whether or not the entity of your choice is damaged by the firework explosion
   → ❌ Firework explosions don't deal damage to numerous amounts of entities.

Expected behavior

Firework explosions would deal damage to all entities.

Code Analysis

Code analysis done by @unknown

The reason this is happening is that when the explosion damage is happening it only checks from living entities which excludes End Crystals and Ender Dragons. Changing it to check for all Entities fixes it

Current Code

net/minecraft/world/entity/projectile/FireworkRocketEntity.java

private void dealExplosionDamage() {
...
         for(LivingEntity livingentity : this.level.getEntitiesOfClass(LivingEntity.class, this.getBoundingBox().inflate(5.0D))) {
            if (livingentity != this.attachedToEntity && !(this.distanceToSqr(livingentity) > 25.0D)) {
               boolean flag = false;

               for(int i = 0; i < 2; ++i) {
                  Vec3 vec31 = new Vec3(livingentity.getX(), livingentity.getY(0.5D * (double)i), livingentity.getZ());
                  HitResult hitresult = this.level.clip(new ClipContext(vec3, vec31, ClipContext.Block.COLLIDER, ClipContext.Fluid.NONE, this));
                  if (hitresult.getType() == HitResult.Type.MISS) {
                     flag = true;
                     break;
                  }
               }
   }
...

Fixed Code

net/minecraft/world/entity/projectile/FireworkRocketEntity.java

private void dealExplosionDamage() {
...
         //Changing from Living Entity to Entity fixes MC-111442
         for(Entity entity: this.level.getEntitiesOfClass(Entity.class, this.getBoundingBox().inflate(5.0D))) {
            if (entity != this.attachedToEntity && !(this.distanceToSqr(livingentity) > 25.0D)) {
               boolean flag = false;

               for(int i = 0; i < 2; ++i) {
                  Vec3 vec31 = new Vec3(entity.getX(), entity.getY(0.5D * (double)i), entity.getZ());
                  HitResult hitresult = this.level.clip(new ClipContext(vec3, vec31, ClipContext.Block.COLLIDER, ClipContext.Fluid.NONE, this));
                  if (hitresult.getType() == HitResult.Type.MISS) {
                     flag = true;
                     break;
                  }
               }

               //Deny items and experience being destroyed by the rocket
               //Could probably be done better
               if(entity instanceof  ItemEntity || entity instanceof ExperienceOrb)
               {
                  flag = false;
               }
...