[MC-123289] EntityTag doesn't work on all items summoning entities

Some items summoning an entity when used don't apply the EntityTag tag to the summoned entity.

Affected items

~~Item Frames~~ (19w07a)
~~Paintings~~ (19w07a)
Minecarts
Boats
End Crystals
Fireworks
Throwable items (Ender Pearl, Snowball, ...) (Should also work with dispensers) (Lingering potions could have their changes stored in themselves as thrown potions aswell as in the area effect cloud they will summon)
Arrows (If an arrow item is being used which has the tag)
Leads (
Maybe even fishing bobbers when summoned using a rod which has the tag (for consistency)

How to reproduce

Run the command:
```
/give @s oak_boat{EntityTag:{Tags:["test"]}}
```
-> ❌ When placed, the entity summoned does not have the tag test.

Original Description

I'm not sure if this is just a bug or works as intended but I noticed that giving item frames an "EntityTag" tag won't apply any changes when you place them.

I feel like all items summoning entities should support the "EntityTag" tag. I don't see why it should only work for armor stands & spawn eggs. It can be useful for all entities.

Linked issues

is duplicated by 1

MC-295403 End Crystals do not accept the "entity_data" item component Resolved

Attachments

MC-123289.mp4

Comments 33

Erik Broes 2017-12-18T14:24:14Z

I don't think there is any good usecase for this?

Teixon 2017-12-18T18:32:54Z

Well, I'd use it to target the blockspace you placed this item frame in. So you could use it to place different blocks based on its nbt-data. I'd use it for a vanilla mod in which I don't want to retexture any blocks but have entities act like the "custom blocks". I'd just put a durability affected item on an armor stand's head and retexture the item based on its damage value. Since you're now able to place item frames on the ceiling/floor this would be even more useful.

Another thing to mention: armor stands can't be placed in a 1 block high space. They always need at least 2 blocks. This is where item frames come in handy. And the issue with spawn eggs: You can use them to overwrite mob spawners which would ruin a survival world.

So an item frame would be the perfect target entity in this case.

Erik Broes 2017-12-18T19:40:15Z

Thanks! we'll look into it 🙂

user-f2760 2017-12-18T19:50:01Z

Small suggestion in that case: do it for paintings too, to make it consistent.

Teixon 2017-12-18T20:00:59Z

Yes! Also, I wonder if throwable items (snowball, etc.) could have it too? I can see some good uses for that aswell.

23 more comments

Teixon 2017-12-18T20:12:59Z

And a nice addition to armor stands would be to remove the 2 block space requirement if the armor stand's EntityTag nbt-data has "Small:1b" set. [MC-123453]

marcono1234 2017-12-21T14:35:13Z

@@unknown, this might not be (very easily) fixable because armor stands can be placed inside replacable blocks, however the methods used by the normal mob spawning only check if blocks have a collision box.

Either way you should create a separate report for that and please comment the report number here afterwards then please.

Teixon 2017-12-21T16:14:39Z

Nah it's ok I just hope item frames will get fixed.

FaRo1 2017-12-21T16:16:58Z

No, seriously, please create a report. It's a bug and should be reported so that it can get fixed.

Teixon 2017-12-21T16:23:12Z

It's a bug? Always thought this was just how it works since armor stands are 2 blocks high normally.

FaRo1 2017-12-21T16:34:59Z

But small armor stands not. You can place a block above them afterwards, right?

Teixon 2017-12-21T16:41:56Z

"Afterwards" yes, but "before" doesn't work. Would make sense if you could.

Aaron Rhodes 2018-02-05T16:03:12Z

If you want more uses for this, then an example would be: a player wants to place an item frame with an item already in it. Useful for decorating with item frames that all have the same item in them. Or perhaps a map that the player can place in a single click, which would remove the hassle of targeting the exact item frame the player just placed in order to run a /data merge to get the same result. The player would also be able to place silent item frames so that using a repeat command block to change it's item won't cause a loud and annoying sound. These are uses that require the item frame itself, and not just the use of a 1 block space, and I'm sure there are plenty more uses for it. The main issue is that there is no way to pinpoint the exact item frame that was just placed if there is no custom data set to it on placement.

Also, the use of spawn eggs could be improved if there was an equivalent to the CanPlaceOn tag that lists blocks that it can't be placed on, such as spawners. Not meant as a feature suggestion, just an explanation of why spawn eggs are less of a viable option compared to item frames or armor stands.

FaRo1 2018-02-13T21:28:07Z

@unknown I think you're confusing entities and items. The tag works already for spawn eggs (which includes most entities) and armour stands, just not for item frames.

Teixon 2018-02-13T21:40:07Z

Well there are still some others like paintings, end crystals, throwable items like potions, snowballs, .. could work aswell imo. Maybe even arrows.

FaRo1 2018-02-13T21:46:11Z

Yes, that's right. Do you want to put a list into the report or should I?

BisUmTo 2019-02-19T13:20:09Z

There is this bug in 1.14s snapshots too

FaRo1 2019-02-19T13:29:57Z

Which one did you test?